Ensured that 'Colour Columns by Structure' check box works correctly in Column Structure dialog #8240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdstern
approved these changes
Apr 23, 2023
There was a problem hiding this comment.
Fine - I have approved. Sometime later I would like to add options to choose which colours, but that is very low now on my priority list. So I have just changed the pull request into fixes partially. And approved. Over to @lloyddewit
lloyddewit
approved these changes
Apr 24, 2023
lloyddewit
changed the title
lloyddewit
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes partially #7232
I made the checkbox for the colour the default. So it starts with the checkbox ticked and also fixed the problem of the dialogue remembering the variables in each control when the dialogue is re-opened.
@rdstern this PR is ready for review.
Thanks