Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensured that Key checkbox correctly set in Row Names/Numbers dialog #8290

Merged
merged 4 commits into from
May 24, 2023

Conversation

Vitalis95
Copy link
Contributor

Fixes partially #8216
@rdstern , @lloyddewit , the Make the Column a Key for the Data Frame control is unchecked if there is existing key in the data frame.

rdstern
rdstern previously approved these changes May 4, 2023
Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@lloyddewit
Copy link
Contributor

@Vitalis95 If you can implement and resolve @N-thony 's comment above, then I can review/approve/merge.
Thanks

@Vitalis95
Copy link
Contributor Author

@lloyddewit , it is fine now

@lloyddewit lloyddewit added the bug label May 24, 2023
@lloyddewit lloyddewit changed the title Unchecking the Key control if there is Key variable in data frame in Row Names/Numbers dlg Ensured that Key checkbox correctly set in Row Names/Numbers dialog May 24, 2023
@lloyddewit lloyddewit merged commit 2d306b7 into IDEMSInternational:master May 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants