New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved the Titles tab on the Graphs subdialog #8337
Conversation
updating master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vitalis95 this is looking very promising. Just what I was hoping for.
a) Could you also tempt the Caption to be multi-line as we do in the PICSA climatic sub-dialogue.
b) Could you also add the tooltip from there that explains that \n can be used to provide a multiline caption.
Here is an example, that gave me a small surprise. The x and y axis sizes seemed to be affected by the changes in the font size for the title, or subtitle. (I would like also to be able to choose their size, but perhaps not there!
d) There is something odd with your code and the defaults. I get a very different size for the plot title and sub-title when I have the defaults of 20 and 15, compared with 20.1 and 15.1. Could thise defaults be the actual ones as well as not linking to the x axis and y axis sizes.
e) Could the Tag and New Legend Title have checkboxes, default unchecked, The text is only visible when checked. Maybe the tag and also perhaps the Legend needs the Size too, and I am not sure the Legend title works yet?
@rdstern have a look at it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vitalis95 this is looking good now.
a) When I first unchecked the tag it was as follows:
But when I returned to the sub-dialog the size of the tag had changed to 8?
b) In the resulting ggplot I am not sure all the components are the size givewn - sometimes it is given, and sometimes not, so it presumably uses the default. I suggest anytime a component is used (i.e. not null) then you explicitely put the size into the R command.
c) I am not sure what the Fill is doing for the new legend? Doesn't that provide a colour? If so, then the type of control is not correct.
@rdstern , the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vitalis95 here is the graph after input of a title and sub-title and caption.
I think it is probably a single error, but it looks as though the y-axis and x-axis and legends title are the same size as the main title?
@rdstern , have a look at it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vitalis95 this all seems to work well now.
My only problem is the funny 2 parameters for the legend. This entry seems to indicate I am not the only one to be confused.
I suggest you just have the Legend title control there - and still use the fill parameter in the R code that you generate.
Then we can merge.
@rdstern , check it now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vitalis95 great. @lloyddewit over to you
Co-authored-by: lloyddewit <57253949+lloyddewit@users.noreply.github.com>
Co-authored-by: lloyddewit <57253949+lloyddewit@users.noreply.github.com>
Co-authored-by: lloyddewit <57253949+lloyddewit@users.noreply.github.com>
Co-authored-by: lloyddewit <57253949+lloyddewit@users.noreply.github.com>
Co-authored-by: lloyddewit <57253949+lloyddewit@users.noreply.github.com>
Co-authored-by: lloyddewit <57253949+lloyddewit@users.noreply.github.com>
Co-authored-by: lloyddewit <57253949+lloyddewit@users.noreply.github.com>
Co-authored-by: lloyddewit <57253949+lloyddewit@users.noreply.github.com>
Co-authored-by: lloyddewit <57253949+lloyddewit@users.noreply.github.com>
@Vitalis95 Thank you for the changes, I think there are still 2 unresolved comments above, please could you check? |
@lloyddewit , it is fine now. |
@rdstern There are some small changes since your last approval. If you can test/approve again, then we can merge, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Thanks
Fixes #8299
@rdstern @lloyddewit , this PR improves the titles tabs in Plot sub-dialog