Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added appertize workflow for content repos #2200

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Conversation

ChrisMarsh82
Copy link
Collaborator

Description

Created Test-Appertize workflow to push android app to appertize from content repos

Copy link
Collaborator

@jfmcquade jfmcquade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisMarsh82 I've found the PR that originally introduced deployment-specific appetize instances, and added the github environments to manage the deployment-specific secrets: #1864.

There's an explanation in that PR's description of why the environments were set up, and I think that now that we have deployment repos we can get rid of the environments (although the environments implementation is quite interesting). It also explains that the APPETIZE_TOKEN is indeed the same universally, so that secret could be managed as an organisational secret. I'll send you an email with an API token that can be used here.

I think for this current PR, the workflow should be changed so that the APPETIZE_APP_KEY comes directly from a secret on the deployment content repo, whereas the APPETIZE_TOKEN should come from an organisational secret. Maybe this is already the case for the existing action, I'm not certain about where those secrets.* values pull from?

One other minor point: there is a typo in the name of the workflow file, it should be reusable-appetize.yml rather than reusable-appeRtize.yml.

@ChrisMarsh82
Copy link
Collaborator Author

@jfmcquade updated typo.
The secrets work by always coming from the repo. The can have organisational secrets that it can use or override. Therefore no changes are needed for global secrets

Copy link
Collaborator

@jfmcquade jfmcquade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. As discussed, I can manually create an Appetize instance for any deployment that needs one, and then save the associated "app key" to the deployment repo's secrets. After that point, the automated Appetize workflow should work to update the instance for the deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants