Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content: 1.1.9 #12

Merged
merged 2 commits into from
Apr 2, 2024
Merged

content: 1.1.9 #12

merged 2 commits into from
Apr 2, 2024

Conversation

esmeetewinkel
Copy link
Contributor

@esmeetewinkel esmeetewinkel commented Mar 26, 2024

Google Auth config changes following / testing PR IDEMSInternational/open-app-builder#2235

@esmeetewinkel esmeetewinkel added the test - preview Create a preview deployment of the PR label Mar 26, 2024
@esmeetewinkel
Copy link
Contributor Author

@jfmcquade I believe I would need the Appetize action to test whether the Google Auth still works, can you think of any other way?

Copy link

github-actions bot commented Mar 26, 2024

Visit the preview URL for this PR (updated for commit 9ea9ec2):

https://plh-teens-tz--pr12-content-1-1-9-a492antl.web.app

(expires Tue, 09 Apr 2024 15:55:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d0b53cec31298d9c96ba66bad5bd819dda8306ff

@jfmcquade
Copy link
Contributor

jfmcquade commented Mar 26, 2024

@jfmcquade I believe I would need the Appetize action to test whether the Google Auth still works, can you think of any other way?

I think you're right. I can make a local Android build (using this PR's content branch and the feat/deployment-firebase branch of the code repo) and test on an emulator, I will do so and add a review to this PR.

In terms of building to Appetize: the reusable action is available as of PR #2200 on the code repo. I will manually configure an Appetize app for this deployment, as described in my latest comment on that PR. Then all that's left is for @ChrisMarsh82 to make a deployment-level github action on this repo that calls the reusable action.

@esmeetewinkel
Copy link
Contributor Author

@jfmcquade the private.key sits on my device locally, should I store/share that somewhere e.g. on BitWarden?

Copy link
Contributor

@jfmcquade jfmcquade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the auth functionality works as expected, see demo of app running in emulation (built from this content branch and the feat/deployment-firebase branch of the main repo):

emulator.sign.in.mov

I did have to re-add the line in the config that sets the value app_config.APP_AUTHENTICATION_DEFAULTS.enforceLogin = true, see this commit. This setting is not superseded by the firebase.auth.enabled = true setting.

The difference is:

  • firebase.auth.enabled = true means that the feature is initialised so that the Google sign in functionality can be called through the associated github action at runtime.
  • app_config.APP_AUTHENTICATION_DEFAULTS.enforceLogin = true means that authentication is actually enforced at login, with a template that cannot be bypassed until the user has signed in (this can be set to a custom template via the APP_AUTHENTICATION_DEFAULTS.signInTemplate property, the default template name is "sign_in")

As we don't actually use the auth feature for anything other than the initial sign in on launch, we'll currently always set these two properties together, but they do accomplish different things. I think this could be made clearer, although I'm not quite sure how at this stage.

@jfmcquade
Copy link
Contributor

I've added an issue to configure building to Appetize from content repos here.

@jfmcquade jfmcquade merged commit 711d866 into main Apr 2, 2024
3 checks passed
@jfmcquade jfmcquade deleted the content/1.1.9 branch April 2, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test - preview Create a preview deployment of the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants