Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babel Notifications #689

Closed
wants to merge 4 commits into from
Closed

Conversation

BrettMayson
Copy link
Contributor

@BrettMayson BrettMayson commented Jun 4, 2019

When merged this pull request will:

There are going to be some limitation due to where the processing is done and not having enough info in SQF. This seems to be a pretty good setup. https://youtu.be/sIlVnOP0fpI Short demo but I've since switched the player name and language name.

@BrettMayson BrettMayson marked this pull request as ready for review June 5, 2019 05:40
@BrettMayson
Copy link
Contributor Author

I still want to do a little bit more testing, but this is basically final.

@Drofseh
Copy link
Contributor

Drofseh commented Jun 5, 2019

NGL I'm not in love with how this looks.

How will it work when there are multiple people talking, or if you are also talking on the radio at the same time as listening to someone else?

I'd prefer if it showed the language above the players head, similar to how the name/rank/speech indicator are.

Also, correct me if I'm blind, but I don't see a setting to enable/disable it.

@BrettMayson
Copy link
Contributor Author

BrettMayson commented Jun 5, 2019

This will only appear when they speak a different language than when you last heard them, or if you are speaking a different language than them on the first encounter. Not every time they talk.

@TheMagnetar
Copy link
Member

TheMagnetar commented Jun 16, 2019

This works well for close players. However, you get notifications as well when the player is also far away. Additionally, I am not sure if this is going to be good for TvT. You will get constant notifications each time a different player speaks.

What Drofseh proposes would address both issues.

@BrettMayson
Copy link
Contributor Author

I would rather fix the distance issue than switch to the language above their head.

You may not always be able to see the person talking to you. It will only pop up when someone switches languages so you will not get notifications each time someone talks

@TheMagnetar
Copy link
Member

This will still show a hint when a person is whispering but is still within MAX_DIRECT_RANGE. I am mostly concerned of breaking TvT in here.

@BrettMayson
Copy link
Contributor Author

BrettMayson commented Apr 21, 2020

I'd still like to look at this, it's something my community would still like.

As for TvT concerns, I have some ideas.

Options for when to notify:

  • Always
  • If the player speaks the language being heard (Default)
  • Never

Who to notify for:

  • Everyone
  • Same Side (Default)
  • Same Group

Range slider from 1m to MAX_DIRECT_RANGE that is default to 10m, could even scale with volume, whisper would be range / 2, yelling would be range * 2

I think that would make it configurable enough that groups could get a setting they are happy with, or disable it outright.

@TheMagnetar
Copy link
Member

Your ideas make sense on TvT. @jonpas any other suggestions?

@jonpas
Copy link
Member

jonpas commented Apr 25, 2020

Yeah that sounds perfect to me really.

@jonpas
Copy link
Member

jonpas commented Feb 24, 2021

Progress? :D

@BrettMayson
Copy link
Contributor Author

I do want to finish this, it's just been low on the todo list, after HEMTT...

@jonpas
Copy link
Member

jonpas commented Feb 24, 2021

👍 HEMTT first, absolutely. :P

@jonpas
Copy link
Member

jonpas commented Sep 14, 2023

No further activity and interest, feel free to re-open though.

@jonpas jonpas closed this Sep 14, 2023
@mrschick
Copy link
Contributor

Another way to make spoken languages easily recognizable could be a voice pitcher.

Since I guess that in the vast majority of missions a translator wouldn't speak more than 3 languages, his "native" language (the first langID in his spokenLanguages Array) would nave normal pitch, the second higher and third lower.

When cycling spoken languages via AltGr, the info text in the bottom right could indicate "normal/higher/lower pitch" below the language name, to allow the player to always look up how each of his spoken languages should sound like.

I'm interested in implementing this but don't possess the TS3 scripting notions that are most likely required for it, yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language notification
5 participants