Fix for cumath.sqrt usage, reported by @julian121266

IDSIA · Nov 17, 2015 · 4f69701 · 4f69701
1 parent f35dae5
commit 4f69701
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/brainstorm/handlers/pycuda_handler.py b/brainstorm/handlers/pycuda_handler.py
@@ -363,7 +363,7 @@ def split_add_tt(self, x, out_a, out_b):
                         block=block, grid=grid)
 
     def sqrt_t(self, a, out):
-        cumath.sqrt(a, out)
+        cumath.sqrt(a, out=out)
 
     def subtract_mv(self, m, v, out):
         cumisc.binaryop_matvec('-', m, v, None, out, None)

diff --git a/brainstorm/tests/test_handlers_against_reference.py b/brainstorm/tests/test_handlers_against_reference.py
@@ -283,6 +283,17 @@ def test_log_t(handler):
         assert operation_check(handler, 'log_t', ref_args)
 
 
+@pytest.mark.parametrize("handler", non_default_handlers, ids=handler_ids)
+def test_sqrt_t(handler):
+    list_a = get_random_arrays(some_nd_shapes)
+
+    for a in list_a:
+        a += 10  # to remove negatives
+        out = np.zeros_like(a, dtype=ref_dtype)
+        ref_args = (a, out)
+        assert operation_check(handler, 'sqrt_t', ref_args)
+
+
 @pytest.mark.parametrize("handler", non_default_handlers, ids=handler_ids)
 def test_abs_t(handler):
     list_a = get_random_arrays(some_nd_shapes)