add option to pass existing MongoClient instance to MongoObserver

The point of this is to allow one to avoid creating redundant instances of MongoClient
IDSIA · Apr 13, 2018 · 38bbb7f · 38bbb7f
1 parent 5bbdf20
commit 38bbb7f
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/sacred/observers/mongo.py b/sacred/observers/mongo.py
@@ -54,10 +54,15 @@ class MongoObserver(RunObserver):
 
     @staticmethod
     def create(url='localhost', db_name='sacred', collection='runs',
-               overwrite=None, priority=DEFAULT_MONGO_PRIORITY, **kwargs):
+               overwrite=None, priority=DEFAULT_MONGO_PRIORITY,
+               client=None,**kwargs):
         import pymongo
         import gridfs
-        client = pymongo.MongoClient(url, **kwargs)
+
+        if client is not None:
+            assert isinstance(client, pymongo.MongoClient)
+        else:
+            client = pymongo.MongoClient(url, **kwargs)
         database = client[db_name]
         if collection in MongoObserver.COLLECTION_NAME_BLACKLIST:
             raise KeyError('Collection name "{}" is reserved. '