Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow dependencies to be compiled libraries. #362

Merged
merged 2 commits into from
Oct 1, 2018
Merged

Allow dependencies to be compiled libraries. #362

merged 2 commits into from
Oct 1, 2018

Conversation

jnphilipp
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Sep 28, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 83.851% when pulling 6cc24b1 on jnphilipp:upstream into 099715a on IDSIA:master.

@Qwlouse
Copy link
Collaborator

Qwlouse commented Oct 1, 2018

Hi thanks! That is a good idea. Minor improvements: endswith() takes a tuple of suffixes, so you could keep it a single if clause. Also compiled libraries seem to end with '.pyd' on windows, so maybe you could add that suffix to the list too? Thanks.

@Qwlouse
Copy link
Collaborator

Qwlouse commented Oct 1, 2018

Cool, thanks!

@Qwlouse Qwlouse merged commit 83a5ea9 into IDSIA:master Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jnphilipp @coveralls @Qwlouse