Make failed mongo observer dump configurable #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 24, 2019 10:58
In comments and forbidden collections
Qwlouse
approved these changes
May 11, 2019
Qwlouse
reviewed
May 11, 2019
sacred/observers/mongo.py
Outdated
| @@ -297,8 +318,12 @@ def final_save(self, attempts): | |||
| file=sys.stderr) | |||
|
|
|||
| from tempfile import NamedTemporaryFile | |||
| os.makedirs(self.failure_dir, exist_ok=True) | |||
There was a problem hiding this comment.
Actually I just noticed that the exist_ok option is py3 only. You'd have to replace it with a manual check.
rueberger
added a commit
to rueberger/sacred
that referenced
this pull request
Jun 20, 2019
* 'master' of https://github.com/IDSIA/sacred: Release 0.7.5 update dependencies to safer version of SQLAlchemy fixed numpy deprecation warning fix yaml deprecation warning Make config read only (IDSIA#472) Remove broken codacy badge (IDSIA#486) Add queue based observer (IDSIA#471) Run CI against python 36 and 37 (IDSIA#485) Make failed mongo observer dump configurable (IDSIA#462) Make stale time longer (IDSIA#484) Fix a bug where a unicode char in README.rst would fail install (IDSIA#481)
rueberger
pushed a commit
to rueberger/sacred
that referenced
this pull request
Jun 21, 2019
…d into run_kwargs_fix * 'run_kwargs_fix' of github.com-rueberger:rueberger/sacred: Release 0.7.5 update dependencies to safer version of SQLAlchemy fixed numpy deprecation warning fix yaml deprecation warning Make config read only (IDSIA#472) Remove broken codacy badge (IDSIA#486) Add queue based observer (IDSIA#471) Run CI against python 36 and 37 (IDSIA#485) Make failed mongo observer dump configurable (IDSIA#462) Make stale time longer (IDSIA#484) Fix a bug where a unicode char in README.rst would fail install (IDSIA#481)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the option to specify the directory in which the mongo observer should dump. This is only partly resolving issues people have the failing mongo observers, but maybe it is useful anyway.