-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make failed mongo observer dump configurable #462
Make failed mongo observer dump configurable #462
Conversation
In comments and forbidden collections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Configuring the failure directory should be useful, and adding the _id to the dump-file is very nice change. Thanks!
sacred/observers/mongo.py
Outdated
@@ -297,8 +318,12 @@ def final_save(self, attempts): | |||
file=sys.stderr) | |||
|
|||
from tempfile import NamedTemporaryFile | |||
os.makedirs(self.failure_dir, exist_ok=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I just noticed that the exist_ok
option is py3 only. You'd have to replace it with a manual check.
* 'master' of https://github.com/IDSIA/sacred: Release 0.7.5 update dependencies to safer version of SQLAlchemy fixed numpy deprecation warning fix yaml deprecation warning Make config read only (IDSIA#472) Remove broken codacy badge (IDSIA#486) Add queue based observer (IDSIA#471) Run CI against python 36 and 37 (IDSIA#485) Make failed mongo observer dump configurable (IDSIA#462) Make stale time longer (IDSIA#484) Fix a bug where a unicode char in README.rst would fail install (IDSIA#481)
…d into run_kwargs_fix * 'run_kwargs_fix' of github.com-rueberger:rueberger/sacred: Release 0.7.5 update dependencies to safer version of SQLAlchemy fixed numpy deprecation warning fix yaml deprecation warning Make config read only (IDSIA#472) Remove broken codacy badge (IDSIA#486) Add queue based observer (IDSIA#471) Run CI against python 36 and 37 (IDSIA#485) Make failed mongo observer dump configurable (IDSIA#462) Make stale time longer (IDSIA#484) Fix a bug where a unicode char in README.rst would fail install (IDSIA#481)
Add the option to specify the directory in which the mongo observer should dump. This is only partly resolving issues people have the failing mongo observers, but maybe it is useful anyway.