FileObserver setup concurrent-safe #473
Conversation
| # unittest.mock requires python >=3.3 | ||
| if mock is not None: | ||
| with pytest.raises(FileExistsError): | ||
| with mock.patch('os.mkdir', mkdir_raises_file_exists): |
There was a problem hiding this comment.
I think you might use pytest's monkeypatch here to avoid the extra logic for Python 2
There was a problem hiding this comment.
Good recommendation, thank you!
.travis.yml
Outdated
| @@ -14,6 +14,8 @@ matrix: | |||
| env: TOX_ENV=tensorflow-2 | |||
| - python: "3.6" | |||
| env: TOX_ENV=flake8 | |||
| - python: "2.7" | |||
There was a problem hiding this comment.
I do not think we need extra coverage for py27. I hope to deprecate it soon anyway
There was a problem hiding this comment.
Coveralls did not accept the PR, because some py2 specific paths (e.g. here) were not tested.
There was a problem hiding this comment.
If it is just that it doesn't matter. We can still merge :D
There was a problem hiding this comment.
I reverted this commit.
| if _id is None: | ||
| self.dir = tempfile.mkdtemp(prefix='run_', dir=self.basedir) |
There was a problem hiding this comment.
This whole block could be placed in its own method to increase readability.
There was a problem hiding this comment.
I separated to a new method. Please review whether it still works like you expect.
Co-Authored-By: Rüdiger Busche <ruedigerbusche@web.de>
This reverts commit 025c66a.
The FileStorage observer usually works great for me in concurrent environments (e.g. 50 nodes writing simultaneous). Only at the very first runs, some die with an exception because they try to create the storage directories simultaneously. This PR tries to fix this by the following changes: