Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python version in appveyor #528

Merged
merged 2 commits into from
Jul 23, 2019
Merged

Conversation

gabrieldemarmiesse
Copy link
Collaborator

@gabrieldemarmiesse gabrieldemarmiesse commented Jul 19, 2019

If only python versions of 3.x are supported, it makes sense to test against the oldest one for backward compatibility and the most recent one for forward compatibility. All other versions in the middle won't have unexpected features or behaviors, so I believe they don't need to be tested.

@gabrieldemarmiesse gabrieldemarmiesse marked this pull request as ready for review July 19, 2019 15:56
@coveralls
Copy link

coveralls commented Jul 19, 2019

Coverage Status

Coverage decreased (-0.04%) to 85.551% when pulling aa439fb on gabrieldemarmiesse:change_ci into 854bf59 on IDSIA:master.

@gabrieldemarmiesse gabrieldemarmiesse changed the title Bump python version in appveyor Bump python version in appveyor and remove ci for Py36 Jul 19, 2019
@JarnoRFB
Copy link
Collaborator

As much as I would like to believe that, it feels better to actually test against all supported versions. I think that does not really hurt us. That said it would be great if you could add py37 to appveyor only.

@gabrieldemarmiesse gabrieldemarmiesse changed the title Bump python version in appveyor and remove ci for Py36 Bump python version in appveyor Jul 23, 2019
@gabrieldemarmiesse
Copy link
Collaborator Author

Fair enough

@JarnoRFB
Copy link
Collaborator

Thanks!

@JarnoRFB JarnoRFB merged commit 45cd810 into IDSIA:master Jul 23, 2019
@gabrieldemarmiesse gabrieldemarmiesse deleted the change_ci branch July 23, 2019 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants