Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed FallbackDict implementation. #552

Merged
merged 2 commits into from
Aug 1, 2019
Merged

Removed FallbackDict implementation. #552

merged 2 commits into from
Aug 1, 2019

Conversation

gabrieldemarmiesse
Copy link
Collaborator

@gabrieldemarmiesse gabrieldemarmiesse commented Aug 1, 2019 •
edited

This object is not read-only so I think we can use a simpler implementation.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 85.365% when pulling ec3cd32 on gabrieldemarmiesse:remove_fallbackdict into 2683272 on IDSIA:master.

@gabrieldemarmiesse gabrieldemarmiesse marked this pull request as ready for review August 1, 2019 13:02
@JarnoRFB
Copy link
Collaborator

JarnoRFB commented Aug 1, 2019

As the class does not seem to be needed elsewhere this makes sense and is indeed much simpler.

@JarnoRFB JarnoRFB merged commit bf45fd4 into IDSIA:master Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gabrieldemarmiesse @coveralls @JarnoRFB