Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler organisation to propagate the import errors in command line options. #556

Merged

Conversation

gabrieldemarmiesse
Copy link
Collaborator

@gabrieldemarmiesse gabrieldemarmiesse commented Aug 2, 2019

In pull requests #547 and #554 we ensured that the user would get a proper import error if he/she used observers with optional dependencies.

In this pull request I make sure that the user gets a proper ImportError if using the --enforce-clean command line option.

After this, there is no need for the with_metaclass, parse_mod_deps functions and CheckDependencies class.

It was a fairly complexe piece of code and it's better if we can avoid supporting it.

@coveralls
Copy link

coveralls commented Aug 2, 2019

Coverage Status

Coverage decreased (-0.007%) to 85.321% when pulling 79a8fb4 on gabrieldemarmiesse:remove_complicated_package_check into 6b177b3 on IDSIA:master.

@JarnoRFB
Copy link
Collaborator

JarnoRFB commented Aug 2, 2019

👍

@JarnoRFB JarnoRFB merged commit a181df5 into IDSIA:master Aug 2, 2019
@gabrieldemarmiesse gabrieldemarmiesse deleted the remove_complicated_package_check branch August 2, 2019 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants