Simpler organisation to propagate the import errors in command line options. #556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pull requests #547 and #554 we ensured that the user would get a proper import error if he/she used observers with optional dependencies.
In this pull request I make sure that the user gets a proper ImportError if using the
--enforce-clean
command line option.After this, there is no need for the
with_metaclass
,parse_mod_deps
functions andCheckDependencies
class.It was a fairly complexe piece of code and it's better if we can avoid supporting it.