Some more attributes are Paths now. #558

gabrieldemarmiesse · 2019-08-02T10:43:17Z

We'll be able to drop many str() calls once we drop python 3.5.

coveralls · 2019-08-02T12:06:06Z

Coverage decreased (-0.003%) to 85.325% when pulling b07eb57 on gabrieldemarmiesse:more_more_pathlib into 6b177b3 on IDSIA:master.

sacred/observers/file_storage.py

JarnoRFB · 2019-08-02T12:35:07Z

I think we can avoid os.path in two more places.

Co-Authored-By: Rüdiger Busche <ruedigerbusche@web.de>

gabrieldemarmiesse · 2019-08-02T12:49:51Z

Very true

gabrieldemarmiesse · 2019-08-02T13:33:19Z

Actually it doesn't seem that we can do that. We'll see in another PR if it's possible. Let me revert the changes.

This reverts commit 73a8d0e.

This reverts commit 7d3f263.

JarnoRFB · 2019-08-03T08:14:51Z

alright, seems to have some implications

gabrieldemarmiesse added 5 commits August 2, 2019 12:26

Added pathlib to more stuff.

c30750a

Some more attributes use pathlib.

be75d33

Merge branch 'more_pathlib' into more_more_pathlib

8269194

Fixed json serialization issue;

63158f4

Fix pep8

4cfa710

JarnoRFB reviewed Aug 2, 2019

View reviewed changes

sacred/observers/file_storage.py Show resolved Hide resolved

sacred/observers/file_storage.py Show resolved Hide resolved

gabrieldemarmiesse and others added 2 commits August 2, 2019 14:45

Update sacred/observers/file_storage.py

73a8d0e

Co-Authored-By: Rüdiger Busche <ruedigerbusche@web.de>

Update sacred/observers/file_storage.py

7d3f263

Co-Authored-By: Rüdiger Busche <ruedigerbusche@web.de>

gabrieldemarmiesse added 2 commits August 2, 2019 15:34

Revert "Update sacred/observers/file_storage.py"

846c760

This reverts commit 73a8d0e.

Revert "Update sacred/observers/file_storage.py"

b07eb57

This reverts commit 7d3f263.

JarnoRFB merged commit 4c79484 into IDSIA:master Aug 3, 2019

Provide feedback