Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using pathlib to simplify is_local_source. #559

Merged
merged 6 commits into from
Aug 2, 2019
Merged

Using pathlib to simplify is_local_source. #559

merged 6 commits into from
Aug 2, 2019

Conversation

gabrieldemarmiesse
Copy link
Collaborator

@gabrieldemarmiesse gabrieldemarmiesse commented Aug 2, 2019 •
edited
Loading

After testing, replacing os.path.abspath(os.path.realpath()) by .resolve() breaks the build on Windows. Let's keep it like that for now, we'll see later how we remove it.

@coveralls
Copy link

coveralls commented Aug 2, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 85.31% when pulling 43ef7cb on gabrieldemarmiesse:using_pathlib_in_dependencies1 into a181df5 on IDSIA:master.

Qwlouse
Qwlouse approved these changes Aug 2, 2019
View reviewed changes
Copy link
Collaborator

@Qwlouse Qwlouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution using in filename.parents. Gotta remember that trick. :-)

@Qwlouse Qwlouse merged commit d63e531 into IDSIA:master Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qwlouse Qwlouse Qwlouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gabrieldemarmiesse @coveralls @Qwlouse