Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preset distribution: do not duplicate ingredient path #777

Merged
merged 2 commits into from Oct 30, 2020

Conversation

AdamGleave
Copy link
Contributor

#769 had a typo that causes the scaffolding path to be concatenated twice. This PR fixes that typo and adds a test case for one instance which broke (passes in old Sacred, fails before this PR, passes after this PR).

@AdamGleave
Copy link
Contributor Author

@thequilo for review

Copy link
Collaborator

@thequilo thequilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think this bug slipped through in one of my previous PRs, so thanks for fixing!

@thequilo thequilo merged commit 7dde5ff into IDSIA:master Oct 30, 2020
@AdamGleave AdamGleave deleted the fix-preset branch October 30, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants