Mui admin app auth #134

sidravi1 · 2024-03-19T12:49:25Z

Reviewer: @amiraliemami
Estimate: 2 hrs

Ticket

Fixes: 408

Description, Motivation and Context

Goal

Setup auth/access controls for new MUI Admin app

Changes

new AuthProvider component
new login screen
components disabled if "readonly"

How has this been tested?

Only through the UI.

Checklist

Fill with x for completed. Delete any lines that are not relevant

My code follows the style guidelines of this project
I have reviewed my own code to ensure good quality
I have tested the functionality of my code to ensure it works as intended
I have resolved merge conflicts
I have updated the automated tests (if applicable)
I have updated the requirements (if applicable)
I have updated the README file (if applicable)
I have updated affected documentation (if applicable)

admin_app_2/package.json

admin_app_2/src/app/content/edit/page.tsx

admin_app_2/src/app/content/layout.tsx

admin_app_2/src/app/content/page.tsx

admin_app_2/src/app/login/page.tsx

admin_app_2/src/components/ContentModal.tsx

admin_app_2/src/components/NavBar.tsx

admin_app_2/src/components/ProtectedComponent.tsx

admin_app_2/src/utils/api.ts

amiraliemami

Thanks for this - learned a lot!

Left some comments - three major things I came across to fix before merge:

Refreshing the page resets the permissions to the default value set in the auth.tsx file (see comment on there).
Edit page's useEffect still runs and fetches content in the background even with just readonly access (see comment).
Edit and New buttons' links still work even on readonly. Suggested fixes.

Thanks!

admin_app_2/src/app/content/page.tsx

admin_app_2/src/components/ContentCard.tsx

admin_app_2/src/utils/auth.tsx

admin_app_2/src/utils/api.ts

admin_app_2/src/app/content/edit/page.tsx

admin_app_2/src/components/ProtectedComponent.tsx

admin_app_2/src/app/login/page.tsx

admin_app_2/src/app/content/layout.tsx

admin_app_2/src/utils/auth.tsx

Co-authored-by: Amir Emami <41763233+amiraliemami@users.noreply.github.com>

amiraliemami

Thanks for the responses. Approving to unblock merging for you tonight but two things to fix before merge:

Accept suggestions on button links
Auth state loss on refresh

Thanks!

* sort results by content_id * Auth and access level * fixes from review

* MUI content pages (#130) Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors * Mui admin app auth (#134) * sort results by content_id * Auth and access level * fixes from review * HOTFIX: Layout import missing from "ProtectedComponent.tsx" * MUI improvements + search bar + navbar activation (#131) * MUI content pages (#130) Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors * address leftover PR#130 comments * remove unnecessary spacing on cards * Make page buttons circular and smaller * cleanup imports * add max count to title input * Revert text box identifiers to reflect wireframe * Cleanup text boxes in Edit * add date back to cards to reflect wireframe * date to 12hr format * add space to bottom of page * reduce cardgrid density * change all instances of content_id to number (some where string) * improve delete button and modal * use the Content type in main grid * Add skeleton of search bar * Implement search functionality! * remove unnecessary wrapper * Move SearchBar and PageNavigation to components * Move sx parameters out of SearchBar component * Make CardsGrid backdrop persist even without cards on it * Convert Box to FlexBox and revert to 4-columns of cards on large screens * NavBar: add homepage link to AAQ logo * NavBar: enable links (but disable inactive pages) * NavBar: Make logo and user icon smaller * Set max cards back to 12 * Use content_id as key instead of index in Grid component * PR feedback fixes * cleanup imports * Simplify editAccess check boolean (use !editAccess) * Widen gap between date and buttons on cards --------- Co-authored-by: Sid Ravinutala <sid.ravi1@gmail.com> * Replace old admin app with new MUI admin app (#136) * temp - remove old `src` * temp - replace/remove files * move logo png to inside admin app * Add condition for catching missing content_id * TEMP FIX: Disable missingSuspenseWithCSRBailout error. See Jira ticket 424 for details. --------- Co-authored-by: Sid Ravinutala <sid.ravi1@gmail.com>

* sort results by content_id * Auth and access level * fixes from review

* MUI content pages (#130) Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors * Mui admin app auth (#134) * sort results by content_id * Auth and access level * fixes from review * HOTFIX: Layout import missing from "ProtectedComponent.tsx" * MUI improvements + search bar + navbar activation (#131) * MUI content pages (#130) Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors * address leftover PR#130 comments * remove unnecessary spacing on cards * Make page buttons circular and smaller * cleanup imports * add max count to title input * Revert text box identifiers to reflect wireframe * Cleanup text boxes in Edit * add date back to cards to reflect wireframe * date to 12hr format * add space to bottom of page * reduce cardgrid density * change all instances of content_id to number (some where string) * improve delete button and modal * use the Content type in main grid * Add skeleton of search bar * Implement search functionality! * remove unnecessary wrapper * Move SearchBar and PageNavigation to components * Move sx parameters out of SearchBar component * Make CardsGrid backdrop persist even without cards on it * Convert Box to FlexBox and revert to 4-columns of cards on large screens * NavBar: add homepage link to AAQ logo * NavBar: enable links (but disable inactive pages) * NavBar: Make logo and user icon smaller * Set max cards back to 12 * Use content_id as key instead of index in Grid component * PR feedback fixes * cleanup imports * Simplify editAccess check boolean (use !editAccess) * Widen gap between date and buttons on cards --------- Co-authored-by: Sid Ravinutala <sid.ravi1@gmail.com> * Replace old admin app with new MUI admin app (#136) * temp - remove old `src` * temp - replace/remove files * move logo png to inside admin app * Add condition for catching missing content_id * TEMP FIX: Disable missingSuspenseWithCSRBailout error. See Jira ticket 424 for details. --------- Co-authored-by: Sid Ravinutala <sid.ravi1@gmail.com>

* sort results by content_id * Auth and access level * fixes from review

* MUI content pages (#130) Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors * Mui admin app auth (#134) * sort results by content_id * Auth and access level * fixes from review * HOTFIX: Layout import missing from "ProtectedComponent.tsx" * MUI improvements + search bar + navbar activation (#131) * MUI content pages (#130) Basic content grid Alerts and Snackbars Fixed warnings and errors in console Better modals Better validation errors * address leftover PR#130 comments * remove unnecessary spacing on cards * Make page buttons circular and smaller * cleanup imports * add max count to title input * Revert text box identifiers to reflect wireframe * Cleanup text boxes in Edit * add date back to cards to reflect wireframe * date to 12hr format * add space to bottom of page * reduce cardgrid density * change all instances of content_id to number (some where string) * improve delete button and modal * use the Content type in main grid * Add skeleton of search bar * Implement search functionality! * remove unnecessary wrapper * Move SearchBar and PageNavigation to components * Move sx parameters out of SearchBar component * Make CardsGrid backdrop persist even without cards on it * Convert Box to FlexBox and revert to 4-columns of cards on large screens * NavBar: add homepage link to AAQ logo * NavBar: enable links (but disable inactive pages) * NavBar: Make logo and user icon smaller * Set max cards back to 12 * Use content_id as key instead of index in Grid component * PR feedback fixes * cleanup imports * Simplify editAccess check boolean (use !editAccess) * Widen gap between date and buttons on cards --------- Co-authored-by: Sid Ravinutala <sid.ravi1@gmail.com> * Replace old admin app with new MUI admin app (#136) * temp - remove old `src` * temp - replace/remove files * move logo png to inside admin app * Add condition for catching missing content_id * TEMP FIX: Disable missingSuspenseWithCSRBailout error. See Jira ticket 424 for details. --------- Co-authored-by: Sid Ravinutala <sid.ravi1@gmail.com>

* sort results by content_id * Auth and access level * fixes from review

sidravi1 added 2 commits March 18, 2024 09:14

sort results by content_id

3ec9d90

Auth and access level

0dd746c

sidravi1 commented Mar 19, 2024

View reviewed changes

sidravi1 requested review from amiraliemami, suzinyou and lickem22 March 19, 2024 14:43

sidravi1 changed the title ~~Mui auth~~ Mui admin app auth Mar 19, 2024

amiraliemami requested changes Mar 20, 2024

View reviewed changes

amiraliemami mentioned this pull request Mar 20, 2024

MUI improvements + search bar + navbar activation #131

Merged

4 tasks

Update admin_app_2/src/components/ProtectedComponent.tsx

f6be833

Co-authored-by: Amir Emami <41763233+amiraliemami@users.noreply.github.com>

amiraliemami self-requested a review March 20, 2024 13:57

amiraliemami approved these changes Mar 20, 2024

View reviewed changes

fixes from review

da12a0f

sidravi1 merged commit a7cc000 into feature-mui-admin Mar 20, 2024
1 check passed

sidravi1 deleted the mui-auth branch March 20, 2024 16:00

amiraliemami pushed a commit that referenced this pull request Mar 21, 2024

Mui admin app auth (#134)

ab95963

* sort results by content_id * Auth and access level * fixes from review

lickem22 pushed a commit that referenced this pull request Mar 22, 2024

Mui admin app auth (#134)

98d2aa6

* sort results by content_id * Auth and access level * fixes from review

lickem22 pushed a commit that referenced this pull request Mar 22, 2024

Mui admin app auth (#134)

a29e5b9

* sort results by content_id * Auth and access level * fixes from review

lickem22 pushed a commit that referenced this pull request Apr 11, 2024

Mui admin app auth (#134)

ee69d19

* sort results by content_id * Auth and access level * fixes from review

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mui admin app auth #134

Mui admin app auth #134

sidravi1 commented Mar 19, 2024 •

edited by amiraliemami

Loading

amiraliemami left a comment

amiraliemami left a comment

Mui admin app auth #134

Mui admin app auth #134

Conversation

sidravi1 commented Mar 19, 2024 • edited by amiraliemami Loading

Ticket

Description, Motivation and Context

Goal

Changes

How has this been tested?

Checklist

amiraliemami left a comment

Choose a reason for hiding this comment

amiraliemami left a comment

Choose a reason for hiding this comment

sidravi1 commented Mar 19, 2024 •

edited by amiraliemami

Loading