Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve and delete multilingual content #140

Merged
merged 10 commits into from
Mar 29, 2024

Conversation

lickem22
Copy link
Contributor

@lickem22 lickem22 commented Mar 28, 2024

Reviewer:@amirali

Estimate: 1h

Ticket

Fixes:AAQ-429

Description, Motivation and Context

Goal

The goal of this PR is to be able to retrieve and delete multilingual contents

Changes

On the backend side:

  • Update the retrieve content endpoint
  • Update the retrieve content endpoint
    On the frontend side:
  • Updated the LanguageButtonBar to take data from the DB.
  • Updated the content modal to get data from DB.

How has this been tested?

The contents have been added manually in different language to test displaying and deleting them.

Checklist

Fill with x for completed. Delete any lines that are not relevant

  • My code follows the style guidelines of this project
  • I have reviewed my own code to ensure good quality
  • I have tested the functionality of my code to ensure it works as intended
  • I have resolved merge conflicts
  • I have updated the automated tests (if applicable)
  • I have updated the requirements (if applicable)
  • I have updated the README file (if applicable)
  • I have updated affected documentation (if applicable)

Copy link
Collaborator

@amiraliemami amiraliemami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice code! Left some comments + two quick cleanup commits.

core_backend/app/contents/routers.py Outdated Show resolved Hide resolved
admin_app/src/app/content/page.tsx Show resolved Hide resolved
core_backend/app/contents/routers.py Show resolved Hide resolved
admin_app/src/utils/api.ts Show resolved Hide resolved
admin_app/src/app/content/page.tsx Show resolved Hide resolved
admin_app/src/components/ContentCard.tsx Show resolved Hide resolved
admin_app/src/components/ContentModal.tsx Show resolved Hide resolved
@lickem22 lickem22 merged commit 78a388e into feature-multilingual Mar 29, 2024
3 checks passed
lickem22 added a commit that referenced this pull request Mar 29, 2024
* List content on frontend

* Add frontend changes

* Update retrieve language

* Delete language

* Fix conflicts

* fix linting

* format code and remove extra space above add button

* Improve language filter aesthetics and resizing behaviour

* Quick cleanup

---------

Co-authored-by: amir_emami <amirali1376@gmail.com>
lickem22 added a commit that referenced this pull request Apr 4, 2024
* List content on frontend

* Add frontend changes

* Update retrieve language

* Delete language

* Fix conflicts

* fix linting

* edit contents

* Retrieve and delete multilingual content (#140)

* List content on frontend

* Add frontend changes

* Update retrieve language

* Delete language

* Fix conflicts

* fix linting

* format code and remove extra space above add button

* Improve language filter aesthetics and resizing behaviour

* Quick cleanup

---------

Co-authored-by: amir_emami <amirali1376@gmail.com>

* Cleanup

* Frontend changes

* Add default language

* Remove deactivated language for edit

* Fix font bug

* Remove emotion/server

* Fix typos

* Remove package.json

---------

Co-authored-by: amir_emami <amirali1376@gmail.com>
suzinyou added a commit that referenced this pull request Apr 9, 2024
* List content on frontend

* Add frontend changes

* Update retrieve language

* Delete language

* Fix conflicts

* fix linting

* edit contents

* Retrieve and delete multilingual content (#140)

* List content on frontend

* Add frontend changes

* Update retrieve language

* Delete language

* Fix conflicts

* fix linting

* format code and remove extra space above add button

* Improve language filter aesthetics and resizing behaviour

* Quick cleanup

---------

Co-authored-by: amir_emami <amirali1376@gmail.com>

* Cleanup

* Frontend changes

* Add default language

* Remove deactivated language for edit

* Fix font bug

* Add delete contents

* Code refactor to add and delete contents

* Return to landing page when all languages versions are deleted

* Remove emotion/server

* delete package-lock.json

* remove unused imports

* Cleanup

* Fix bugs

* Add requested frontend changes

* Fix text getting blank

* Update content title and texts fields

* add new line at end of package

* Fix duplicated issue

---------

Co-authored-by: amir_emami <amirali1376@gmail.com>
Co-authored-by: Suzin You <7042047+suzinyou@users.noreply.github.com>
@amiraliemami amiraliemami deleted the multilingual/retrieve-content branch April 10, 2024 07:55
lickem22 added a commit that referenced this pull request Apr 11, 2024
* List content on frontend

* Add frontend changes

* Update retrieve language

* Delete language

* Fix conflicts

* fix linting

* edit contents

* Retrieve and delete multilingual content (#140)

* List content on frontend

* Add frontend changes

* Update retrieve language

* Delete language

* Fix conflicts

* fix linting

* format code and remove extra space above add button

* Improve language filter aesthetics and resizing behaviour

* Quick cleanup

---------

Co-authored-by: amir_emami <amirali1376@gmail.com>

* Cleanup

* Frontend changes

* Add default language

* Remove deactivated language for edit

* Fix font bug

* Add delete contents

* Code refactor to add and delete contents

* Return to landing page when all languages versions are deleted

* Remove emotion/server

* delete package-lock.json

* remove unused imports

* Add tests

* Clean up

* Fix frontend bug

* fix frontend bugs

* Update admin_app/package.json

Co-authored-by: Suzin You <7042047+suzinyou@users.noreply.github.com>

---------

Co-authored-by: amir_emami <amirali1376@gmail.com>
Co-authored-by: Suzin You <7042047+suzinyou@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants