Skip to content

Commit

Permalink
fix(comp:icon): 'info' and 'exclamation' are exchanged (#1525)
Browse files Browse the repository at this point in the history
  • Loading branch information
danranVm committed Apr 4, 2023
1 parent c758931 commit dc98fae
Show file tree
Hide file tree
Showing 11 changed files with 25 additions and 16 deletions.
1 change: 1 addition & 0 deletions packages/components/button/style/themes/default.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// style dependencies
import '@idux/components/_private/wave/style/themes/default'
import '@idux/components/icon/style/themes/default'
import '@idux/components/space/style/themes/default'

import './default.less'
1 change: 1 addition & 0 deletions packages/components/button/style/themes/seer.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// style dependencies
import '@idux/components/_private/wave/style/themes/seer'
import '@idux/components/icon/style/themes/seer'
import '@idux/components/space/style/themes/seer'

import './seer.less'
6 changes: 3 additions & 3 deletions packages/components/config/src/defaultConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ export const defaultConfig: GlobalConfig = {
closable: false,
icon: {
success: 'check-circle',
error: 'info-circle',
error: 'exclamation-circle',
info: 'bulb',
warning: 'exclamation-circle',
offline: 'exclamation-circle',
warning: 'info-circle',
offline: 'info-circle',
},
},
anchor: {
Expand Down
1 change: 1 addition & 0 deletions packages/components/icon/demo/all.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ export const allIcons = [
'exception',
'exclamation-circle-filled',
'exclamation-circle',
'exclamation',
'exit',
'expand',
'export',
Expand Down
11 changes: 8 additions & 3 deletions packages/components/icon/src/definitions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,12 @@ export const ExclamationCircleFilled = {

export const ExclamationCircle = {
name: 'exclamation-circle',
svg: '<svg viewBox="0 0 1024 1024" focusable="false"><path d="M512 960c247.424 0 448-200.576 448-448S759.424 64 512 64 64 264.576 64 512s200.576 448 448 448Zm0-64c-212.077 0-384-171.923-384-384s171.923-384 384-384 384 171.923 384 384-171.923 384-384 384Zm19.2-576c6.967 0 12.634-5.566 12.796-12.493L544 268.8c0-6.967-5.566-12.634-12.493-12.796L492.8 256c-6.967 0-12.634 5.566-12.796 12.493L480 307.2c0 6.967 5.566 12.634 12.493 12.796L531.2 320Zm0 448c6.967 0 12.634-5.566 12.796-12.493L544 396.8c0-6.967-5.566-12.634-12.493-12.8H492.8c-6.967 0-12.634 5.566-12.796 12.493L480 755.2c0 6.967 5.566 12.634 12.493 12.8H531.2Z"/></svg>',
svg: '<svg viewBox="0 0 1024 1024" focusable="false"><path d="M512 64c247.424 0 448 200.576 448 448S759.424 960 512 960 64 759.424 64 512 264.576 64 512 64Zm0 64c-212.077 0-384 171.923-384 384s171.923 384 384 384 384-171.923 384-384-171.923-384-384-384Zm19.2 576c6.967 0 12.634 5.566 12.796 12.493L544 755.2c0 6.967-5.566 12.634-12.493 12.796L492.8 768c-6.967 0-12.634-5.566-12.796-12.493L480 716.8c0-6.967 5.566-12.634 12.493-12.796L531.2 704Zm0-448c6.967 0 12.634 5.566 12.796 12.493L544 627.2c0 6.967-5.566 12.634-12.493 12.8H492.8c-6.967 0-12.634-5.566-12.796-12.493L480 268.8c0-6.967 5.566-12.634 12.493-12.8H531.2Z"/></svg>',
}

export const Exclamation = {
name: 'exclamation',
svg: '<svg viewBox="0 0 1024 1024" focusable="false"><path d="M550.4 768c14.08 0 25.6 11.52 25.6 25.6v76.8a25.6 25.6 0 0 1-25.6 25.6h-76.8a25.6 25.6 0 0 1-25.6-25.6v-76.8c0-14.08 11.52-25.6 25.6-25.6h76.8zm0-576c14.08 0 25.6 11.52 25.6 25.6v460.8a25.6 25.6 0 0 1-25.6 25.6h-76.8a25.6 25.6 0 0 1-25.6-25.6V217.6c0-14.08 11.52-25.6 25.6-25.6h76.8z"/></svg>',
}

export const Exit = {
Expand Down Expand Up @@ -542,12 +547,12 @@ export const InfoCircleFilled = {

export const InfoCircle = {
name: 'info-circle',
svg: '<svg viewBox="0 0 1024 1024" focusable="false"><path d="M512 64c247.424 0 448 200.576 448 448S759.424 960 512 960 64 759.424 64 512 264.576 64 512 64Zm0 64c-212.077 0-384 171.923-384 384s171.923 384 384 384 384-171.923 384-384-171.923-384-384-384Zm19.2 576c6.967 0 12.634 5.566 12.796 12.493L544 755.2c0 6.967-5.566 12.634-12.493 12.796L492.8 768c-6.967 0-12.634-5.566-12.796-12.493L480 716.8c0-6.967 5.566-12.634 12.493-12.796L531.2 704Zm0-448c6.967 0 12.634 5.566 12.796 12.493L544 627.2c0 6.967-5.566 12.634-12.493 12.8H492.8c-6.967 0-12.634-5.566-12.796-12.493L480 268.8c0-6.967 5.566-12.634 12.493-12.8H531.2Z"/></svg>',
svg: '<svg viewBox="0 0 1024 1024" focusable="false"><path d="M512 960c247.424 0 448-200.576 448-448S759.424 64 512 64 64 264.576 64 512s200.576 448 448 448Zm0-64c-212.077 0-384-171.923-384-384s171.923-384 384-384 384 171.923 384 384-171.923 384-384 384Zm19.2-576c6.967 0 12.634-5.566 12.796-12.493L544 268.8c0-6.967-5.566-12.634-12.493-12.796L492.8 256c-6.967 0-12.634 5.566-12.796 12.493L480 307.2c0 6.967 5.566 12.634 12.493 12.796L531.2 320Zm0 448c6.967 0 12.634-5.566 12.796-12.493L544 396.8c0-6.967-5.566-12.634-12.493-12.8H492.8c-6.967 0-12.634 5.566-12.796 12.493L480 755.2c0 6.967 5.566 12.634 12.493 12.8H531.2Z"/></svg>',
}

export const Info = {
name: 'info',
svg: '<svg viewBox="0 0 1024 1024" focusable="false"><path d="M550.4 768c14.08 0 25.6 11.52 25.6 25.6v76.8a25.6 25.6 0 0 1-25.6 25.6h-76.8a25.6 25.6 0 0 1-25.6-25.6v-76.8c0-14.08 11.52-25.6 25.6-25.6h76.8zm0-576c14.08 0 25.6 11.52 25.6 25.6v460.8a25.6 25.6 0 0 1-25.6 25.6h-76.8a25.6 25.6 0 0 1-25.6-25.6V217.6c0-14.08 11.52-25.6 25.6-25.6h76.8z"/></svg>',
svg: '<svg viewBox="0 0 1024 1024" focusable="false"><path d="M448 224a64 64 0 1 0 128 0 64 64 0 1 0-128 0zm96 168h-64c-4.4 0-8 3.6-8 8v464c0 4.4 3.6 8 8 8h64c4.4 0 8-3.6 8-8V400c0-4.4-3.6-8-8-8z"/></svg>',
}

export const Insurance = {
Expand Down
12 changes: 6 additions & 6 deletions packages/components/icon/src/dependencies.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ import {
Down,
Ellipsis,
Empty,
Exclamation,
ExclamationCircle,
ExclamationCircleFilled,
FilterFilled,
Holder,
Info,
InfoCircle,
InfoCircleFilled,
LayoutCompact,
Expand Down Expand Up @@ -82,13 +82,13 @@ export const IDUX_ICON_DEPENDENCIES: IconDefinition[] = [
Down, // Select Table
Ellipsis, // Table
Empty, // Empty
ExclamationCircle, // Message Result Alert Notification
ExclamationCircleFilled, // Modal Popconfirm
InfoCircle, // Message Result Alert Notification
InfoCircleFilled, // Modal Popconfirm
FilterFilled, // Table
Holder, // tree
Info, // Stepper
InfoCircle, // Message Result Alert Notification
InfoCircleFilled, // Modal
Exclamation, // Stepper
ExclamationCircle, // Message Result Alert Notification
ExclamationCircleFilled, // Modal
LayoutCompact, // ProTable
LayoutLarge, // ProTable
LayoutMedium, // ProTable
Expand Down
2 changes: 1 addition & 1 deletion packages/components/stepper/src/StepperItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export default defineComponent({

const statusIcons: Partial<Record<StepperStatus, string>> = {
finish: 'success',
error: 'info',
error: 'exclamation',
}

function renderIcon(
Expand Down
2 changes: 1 addition & 1 deletion scripts/gulp/icons/assets/exclamation-circle.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions scripts/gulp/icons/assets/exclamation.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion scripts/gulp/icons/assets/info-circle.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion scripts/gulp/icons/assets/info.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit dc98fae

Please sign in to comment.