Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:form): support for displaying message in tooltip #1047

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

What is the new behavior?

Other information

@danranVm danranVm linked an issue Jul 28, 2022 that may be closed by this pull request
1 task
@idux-bot
Copy link

idux-bot bot commented Jul 28, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #1047 (1317bf7) into main (0bb2f8e) will decrease coverage by 0.01%.
The diff coverage is 93.42%.

❗ Current head 1317bf7 differs from pull request most recent head 954aad8. Consider uploading reports for the commit 954aad8 to get more accurate results

@@            Coverage Diff             @@
##             main    #1047      +/-   ##
==========================================
- Coverage   93.76%   93.74%   -0.02%     
==========================================
  Files         314      314              
  Lines       29989    30077      +88     
  Branches     3541     3548       +7     
==========================================
+ Hits        28118    28196      +78     
- Misses       1871     1881      +10     
Impacted Files Coverage Δ
packages/components/form/src/FormItem.tsx 93.93% <89.13%> (-3.55%) ⬇️
packages/cdk/popper/src/hooks.ts 98.79% <100.00%> (-0.04%) ⬇️
packages/cdk/popper/src/types.ts 100.00% <100.00%> (ø)
packages/cdk/popper/src/usePopper.ts 97.35% <100.00%> (+0.01%) ⬆️
...ckages/components/_private/overlay/src/Overlay.tsx 97.29% <100.00%> (+0.12%) ⬆️
packages/components/form/src/types.ts 100.00% <100.00%> (ø)
...mponents/notification/src/NotificationProvider.tsx 98.74% <100.00%> (+0.02%) ⬆️
packages/components/notification/src/types.ts 100.00% <100.00%> (ø)
packages/components/tooltip/src/types.ts 100.00% <100.00%> (ø)
...ckages/components/tooltip/src/useTooltipOverlay.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bb2f8e...954aad8. Read the comment docs.

@danranVm danranVm merged commit 67222d1 into IDuxFE:main Jul 29, 2022
@danranVm danranVm deleted the feat-comp-form branch July 29, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[comp:form] 新增气泡式的错误提示
1 participant