Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:table): style update and ellipsis conflicts with column type #1245

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented Nov 1, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

  • 表格配置 ellipsis 后,selectable 列显示省略号
  • 表头分组的样式问题
    image

What is the new behavior?

  • 支持 css variable
  • 样式同步设计规范
  • 修复 ellipsis 在 selectable, expandable 等列的样式问题

Other information

@idux-bot
Copy link

idux-bot bot commented Nov 1, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #1245 (3b57200) into main (d07e914) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 3b57200 differs from pull request most recent head 55b5860. Consider uploading reports for the commit 55b5860 to get more accurate results

@@            Coverage Diff             @@
##             main    #1245      +/-   ##
==========================================
- Coverage   93.05%   93.04%   -0.01%     
==========================================
  Files         320      320              
  Lines       29426    29419       -7     
  Branches     3338     3337       -1     
==========================================
- Hits        27381    27374       -7     
  Misses       2045     2045              
Impacted Files Coverage Δ
packages/components/icon/src/dependencies.ts 99.12% <0.00%> (-0.02%) ⬇️
packages/components/icon/src/definitions.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 44a5353 into IDuxFE:main Nov 1, 2022
@danranVm danranVm deleted the fix-table branch November 1, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant