Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:button): the ButtonGroup extends Space #1279

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented Nov 15, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

What is the new behavior?

  • ButtonGroup 使用 Space 实现,
  • ButtonGroup 的 gap 即为 Space 的 size

Other information

@idux-bot
Copy link

idux-bot bot commented Nov 15, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

❗ No coverage uploaded for pull request base (feature@eaf562c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             feature    #1279   +/-   ##
==========================================
  Coverage           ?   93.03%           
==========================================
  Files              ?      321           
  Lines              ?    29726           
  Branches           ?     3352           
==========================================
  Hits               ?    27657           
  Misses             ?     2069           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 0c7981f into IDuxFE:feature Nov 15, 2022
@danranVm danranVm deleted the feat-button-group branch November 25, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant