Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:button): display to inline-block and remove focus style #1354

Merged
merged 1 commit into from Dec 13, 2022

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

What is the new behavior?

  • 按钮的 dispaly 从 inline-flex => inline-block, 解决在 Space 组件内的行高问题。
  • 移除 focus 样式,同步设计规范。

Other information

@idux-bot
Copy link

idux-bot bot commented Dec 12, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #1354 (32ee6d2) into main (031834e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1354      +/-   ##
==========================================
- Coverage   93.10%   93.10%   -0.01%     
==========================================
  Files         323      323              
  Lines       29917    29916       -1     
  Branches     3397     3397              
==========================================
- Hits        27853    27852       -1     
  Misses       2064     2064              
Impacted Files Coverage Δ
packages/components/button/src/Button.tsx 95.87% <100.00%> (-0.21%) ⬇️
packages/components/icon/src/dependencies.ts 99.16% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 107c03e into IDuxFE:main Dec 13, 2022
@danranVm danranVm deleted the fix-button-line-height branch December 13, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants