Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:button): display to inline-block and remove focus style #1354

Merged
merged 1 commit into from
Dec 13, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 1 addition & 6 deletions packages/components/button/src/Button.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,7 @@ export default defineComponent({

const children: VNodeChild[] = []
if (loading) {
children.push(
// loading 状态下的行高问题
<span class={`${mergedPrefixCls.value}-loading-icon`}>
<IxIcon name="loading"></IxIcon>
</span>,
)
children.push(<IxIcon name="loading"></IxIcon>)
} else if (slots.icon) {
children.push(slots.icon())
} else if (icon) {
Expand Down
43 changes: 15 additions & 28 deletions packages/components/button/style/index.less
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,7 @@
.reset-color(@button-color, @button-background-color);

position: relative;
display: inline-flex;
flex-wrap: nowrap;
align-items: center;
justify-content: center;
display: inline-block;
text-align: center;
white-space: nowrap;
cursor: pointer;
Expand Down Expand Up @@ -44,16 +41,27 @@
content: '\a0';
}

&-loading-icon > .@{icon-prefix},
& > .@{icon-prefix} {
> .@{icon-prefix} {
color: @button-icon-color;
font-size: @button-icon-font-size;
}

&:hover,
&:active,
&-primary,
&-link,
&-danger,
&-ghost,
&-disabled {
> .@{icon-prefix} {
color: inherit;
}
}

> span {
display: inline-block;
}

&-loading-icon + span,
> .@{icon-prefix} + span {
margin-left: @spacing-xs;
}
Expand All @@ -74,7 +82,6 @@
.button-size(@button-height-lg, @button-font-size-lg, @button-min-width-lg, @button-padding-horizontal-lg);

&.@{button-prefix}-icon-only {
.@{button-prefix}-loading-icon > .@{icon-prefix},
> .@{icon-prefix} {
font-size: calc(@button-icon-font-size + 2px);
}
Expand All @@ -85,7 +92,6 @@
.button-size(@button-height-xl, @button-font-size-xl, @button-min-width-xl, @button-padding-horizontal-xl);

&.@{button-prefix}-icon-only {
.@{button-prefix}-loading-icon > .@{icon-prefix},
> .@{icon-prefix} {
font-size: calc(@button-icon-font-size + 4px);
}
Expand All @@ -97,7 +103,6 @@
background-color: @button-primary-background-color;
border-color: @button-primary-background-color;

&:focus,
&:hover {
background-color: @button-primary-background-color-hover;
border-color: @button-primary-background-color-hover;
Expand All @@ -111,7 +116,6 @@

&-default,
&-dashed {
&:focus,
&:hover {
color: @button-primary-background-color-hover;
border-color: @button-primary-background-color-hover;
Expand All @@ -135,7 +139,6 @@
min-width: auto;
height: auto;

&:focus,
&:hover {
color: @button-primary-background-color-hover;
}
Expand All @@ -153,7 +156,6 @@
color: @button-danger-color;
border-color: @button-danger-color;

&:focus,
&:hover {
color: @button-danger-color-hover;
border-color: @button-danger-color-hover;
Expand All @@ -169,7 +171,6 @@
color: @button-primary-color;
background-color: @button-danger-color;

&:focus,
&:hover {
color: @button-primary-color;
background-color: @button-danger-color-hover;
Expand All @@ -185,7 +186,6 @@
color: @button-primary-color;
border-color: @button-ghost-border-color;

&:focus,
&:hover {
color: @button-primary-color;
border-color: @button-ghost-border-color;
Expand All @@ -202,7 +202,6 @@
&-ghost&-danger {
background-color: transparent;

&:focus,
&:hover {
background-color: @button-ghost-background-color-hover;
}
Expand All @@ -216,7 +215,6 @@
color: @button-primary-background-color;
border-color: @button-primary-background-color;

&:focus,
&:hover {
color: @button-primary-background-color-hover;
border-color: @button-primary-background-color-hover;
Expand All @@ -232,7 +230,6 @@
color: @button-danger-color;
border-color: @button-danger-color;

&:focus,
&:hover {
color: @button-danger-color-hover;
border-color: @button-danger-color-hover;
Expand All @@ -249,7 +246,6 @@

&,
&:hover,
&:focus,
&:active {
color: @button-color-disabled;
background-color: @button-background-color-disabled;
Expand All @@ -261,7 +257,6 @@
&-disabled&-text {
&,
&:hover,
&:focus,
&:active {
background-color: transparent;
}
Expand All @@ -270,7 +265,6 @@
&-disabled&-ghost {
&,
&:hover,
&:focus,
&:active {
background-color: @button-ghost-background-color-disabled;
}
Expand Down Expand Up @@ -301,12 +295,6 @@
&-icon-only {
min-width: auto;
}

&-default:not(&-danger):not(&-disabled):not(:hover):not(:focus):not(:active) {
.@{icon-prefix} {
color: @button-icon-color;
}
}
}

.@{button-prefix}-group {
Expand All @@ -316,7 +304,6 @@
z-index: auto;

&:hover,
&:focus,
&:active {
z-index: 2;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/components/button/style/mixin.less
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

height: @height;
min-width: @min-width;
padding: 0 @padding-horizontal;
padding: calc((@height - @font-size - var(--ix-line-height-gutter) - 2px) / 2) @padding-horizontal;

&.@{button-prefix}-circle,
&.@{button-prefix}-square {
Expand Down
4 changes: 4 additions & 0 deletions packages/components/icon/src/dependencies.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import {
ExclamationCircleFilled,
FilterFilled,
Holder,
Info,
InfoCircle,
InfoCircleFilled,
LayoutCompact,
Expand All @@ -51,6 +52,7 @@ import {
RotateRight,
Search,
StarFilled,
Success,
TreeExpand,
TreeUnexpand,
Uncollapse,
Expand Down Expand Up @@ -84,6 +86,7 @@ export const IDUX_ICON_DEPENDENCIES: IconDefinition[] = [
ExclamationCircleFilled, // Modal Popconfirm
FilterFilled, // Table
Holder, // tree
Info, // Stepper
InfoCircle, // Message Result Alert Notification
InfoCircleFilled, // Modal
LayoutCompact, // ProTable
Expand All @@ -104,6 +107,7 @@ export const IDUX_ICON_DEPENDENCIES: IconDefinition[] = [
RotateLeft, // Image
RotateRight, // Image
Search, // Select Transfer
Success, // Stopper
StarFilled, // Rate
User, // Avatar
Uncollapse, // Pro Tree
Expand Down