Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:stepper): stepper tail dashed style isn't working #1458

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

步骤条的连线,由于border-radius的存在,dashed不起作用

What is the new behavior?

去掉border-radius

Other information

@idux-bot
Copy link

idux-bot bot commented Feb 20, 2023

This preview will be available after the AzureCI is passed.

@@ -50,7 +50,6 @@
&::after {
display: inline-block;
height: 100%;
border-radius: 1px;
border-top: @stepper-line-border;
border-right: @stepper-line-border;
transition: border-color @transition-duration-base;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code review:

The code snippet looks quite good and concise. The only issue I can see is the removal of the ‘border-radius’ property. This could affect how the border looks and its functionality. It may be worth considering adding this back in or adjusting the border radius value to a more suitable one.

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #1458 (f5fac79) into main (8ca7a08) will not change coverage.
The diff coverage is n/a.

❗ Current head f5fac79 differs from pull request most recent head 74ef081. Consider uploading reports for the commit 74ef081 to get more accurate results

@@           Coverage Diff           @@
##             main    #1458   +/-   ##
=======================================
  Coverage   92.89%   92.89%           
=======================================
  Files         327      327           
  Lines       30399    30399           
  Branches     3507     3506    -1     
=======================================
  Hits        28238    28238           
  Misses       2161     2161           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm
Copy link
Member

如果视觉规范 要求的就是 dashed 的话,就直接改成 dashed 的呗。

@sallerli1
Copy link
Contributor Author

这个是由于border-radius导致了dashed不生效

@danranVm danranVm merged commit c688624 into IDuxFE:main Feb 23, 2023
@sallerli1 sallerli1 deleted the fix-stepper-tail-style-saller branch July 4, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants