Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:icon): ellipsis icon not right #1522

Merged
merged 1 commit into from Mar 31, 2023

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

省略号图标错误

What is the new behavior?

将错误的省略号图标修改为 ellipsis-vertical,换回原来正确的图标

Other information

@@ -64,6 +64,7 @@ export const allIcons = [
'down',
'download',
'edit',
'ellipsis-vertical',
'ellipsis',
'empty',
'environment',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the review

  1. There is no typos or syntax errors in the code patch, which is a good sign for code quality.

  2. The new icon 'ellipsis-vertical' appears to be added correctly in the list of icons.

  3. It would be nice if the code follows a consistent style and indentation.

  4. It is good to have some basic tests on the code patch to make sure it works as expected.

@@ -0,0 +1 @@
<svg viewBox="0 0 1024 1024" focusable="false"><path d="M576 768c0 4.202-.41 8.364-1.23 12.486a63.86 63.86 0 0 1-3.642 12.006 63.829 63.829 0 0 1-5.914 11.064 63.878 63.878 0 0 1-7.959 9.699 63.878 63.878 0 0 1-9.699 7.96 63.829 63.829 0 0 1-11.064 5.913 63.827 63.827 0 0 1-12.006 3.642A63.83 63.83 0 0 1 512 832a63.83 63.83 0 0 1-12.486-1.23 63.835 63.835 0 0 1-12.006-3.642 63.839 63.839 0 0 1-11.064-5.914 63.857 63.857 0 0 1-9.699-7.959 63.866 63.866 0 0 1-7.96-9.699 63.833 63.833 0 0 1-5.913-11.064 63.839 63.839 0 0 1-3.642-12.006A63.847 63.847 0 0 1 448 768c0-4.202.41-8.364 1.23-12.486a63.839 63.839 0 0 1 3.642-12.006 63.833 63.833 0 0 1 5.914-11.064 63.866 63.866 0 0 1 7.96-9.699 63.857 63.857 0 0 1 9.698-7.96 63.839 63.839 0 0 1 11.064-5.913 63.868 63.868 0 0 1 12.006-3.643A63.861 63.861 0 0 1 512 704c4.202 0 8.364.41 12.486 1.23a63.86 63.86 0 0 1 12.006 3.642 63.829 63.829 0 0 1 11.064 5.914 63.878 63.878 0 0 1 9.699 7.959 63.878 63.878 0 0 1 7.96 9.699 63.829 63.829 0 0 1 5.913 11.064 63.86 63.86 0 0 1 3.643 12.006A63.862 63.862 0 0 1 576 768Zm0-512c0 4.202-.41 8.364-1.23 12.486a63.86 63.86 0 0 1-3.642 12.006 63.829 63.829 0 0 1-5.914 11.064 63.878 63.878 0 0 1-7.959 9.699 63.878 63.878 0 0 1-9.699 7.96 63.829 63.829 0 0 1-11.064 5.913 63.86 63.86 0 0 1-12.006 3.643A63.862 63.862 0 0 1 512 320c-4.202 0-8.364-.41-12.486-1.23a63.868 63.868 0 0 1-12.006-3.642 63.839 63.839 0 0 1-11.064-5.914 63.857 63.857 0 0 1-9.699-7.959 63.866 63.866 0 0 1-7.96-9.699 63.833 63.833 0 0 1-5.913-11.064 63.839 63.839 0 0 1-3.642-12.006A63.847 63.847 0 0 1 448 256c0-4.202.41-8.364 1.23-12.486a63.847 63.847 0 0 1 3.642-12.006 63.843 63.843 0 0 1 5.914-11.064 63.846 63.846 0 0 1 7.96-9.699 63.846 63.846 0 0 1 9.698-7.96 63.843 63.843 0 0 1 11.064-5.913 63.847 63.847 0 0 1 12.006-3.642A63.846 63.846 0 0 1 512 192c4.202 0 8.364.41 12.486 1.23a63.839 63.839 0 0 1 12.006 3.642 63.833 63.833 0 0 1 11.064 5.914 63.866 63.866 0 0 1 9.699 7.96 63.857 63.857 0 0 1 7.96 9.698 63.839 63.839 0 0 1 5.913 11.064 63.868 63.868 0 0 1 3.643 12.006A63.861 63.861 0 0 1 576 256Zm0 256c0 4.202-.41 8.364-1.23 12.486a63.86 63.86 0 0 1-3.642 12.006 63.829 63.829 0 0 1-5.914 11.064 63.878 63.878 0 0 1-7.959 9.699 63.878 63.878 0 0 1-9.699 7.96 63.829 63.829 0 0 1-11.064 5.913 63.827 63.827 0 0 1-12.006 3.642A63.83 63.83 0 0 1 512 576a63.83 63.83 0 0 1-12.486-1.23 63.835 63.835 0 0 1-12.006-3.642 63.839 63.839 0 0 1-11.064-5.914 63.857 63.857 0 0 1-9.699-7.959 63.866 63.866 0 0 1-7.96-9.699 63.833 63.833 0 0 1-5.913-11.064 63.839 63.839 0 0 1-3.642-12.006A63.847 63.847 0 0 1 448 512c0-4.202.41-8.364 1.23-12.486a63.839 63.839 0 0 1 3.642-12.006 63.833 63.833 0 0 1 5.914-11.064 63.866 63.866 0 0 1 7.96-9.699 63.857 63.857 0 0 1 9.698-7.96 63.839 63.839 0 0 1 11.064-5.913 63.868 63.868 0 0 1 12.006-3.643A63.861 63.861 0 0 1 512 448c4.202 0 8.364.41 12.486 1.23a63.86 63.86 0 0 1 12.006 3.642 63.829 63.829 0 0 1 11.064 5.914 63.878 63.878 0 0 1 9.699 7.959 63.878 63.878 0 0 1 7.96 9.699 63.829 63.829 0 0 1 5.913 11.064 63.86 63.86 0 0 1 3.643 12.006A63.862 63.862 0 0 1 576 512Z"/></svg> No newline at end of file
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code review

This code patch appears to be a valid SVG vector graphic. It can be used to generate a shape or pattern for use in web graphics. The code appears to be well written and correctly formatted, with appropriate indentation and spacing. No obvious bugs or risks are present.

However, it would be beneficial to do some additional testing on the code to ensure that it displays properly on all browsers, or if there are any compatibility issues. Additionally, it may be helpful to review the code for any unnecessary or redundant lines of code that can be removed in order to optimize performance and reduce file size.

<svg viewBox="0 0 1024 1024" focusable="false"><defs><style/></defs><path d="M768 448a64 64 0 1 0 0 128 64 64 0 1 0 0-128Zm-256 0a64 64 0 1 0 0 128 64 64 0 1 0 0-128Zm-256 0a64 64 0 1 0 0 128 64 64 0 1 0 0-128Z"/></svg> No newline at end of file
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with a brief code review

The code patch above is used to replace an existing SVG element with a new SVG element. The new SVG element includes a defs element and a style element, which provides additional styling flexibility. It also includes a path element that defines the shape of the SVG.

From a code review perspective, this code should be tested to ensure that the new SVG element renders properly in the browser, and that the styling and shape of the element is correct. Additionally, it could be tested to ensure that the code is optimized for performance and does not cause any compatibility issues.

@idux-bot
Copy link

idux-bot bot commented Mar 31, 2023

This preview will be available after the AzureCI is passed.

<svg viewBox="0 0 1024 1024" focusable="false"><path fill-rule="evenodd" d="M664.88 317.392 552.158 88.983a44.801 44.801 0 0 0-20.346-20.347c-22.188-10.95-49.051-1.84-60.002 20.347L359.024 317.392l-252.048 36.66a44.8 44.8 0 0 0-25.639 13.063l-4.652 5.613c-12.372 17.666-10.484 42.195 5.462 57.739l182.35 177.741L221.5 859.354a44.804 44.804 0 0 0 4.502 28.422l3.51 5.632c12.885 17.632 37.081 23.642 56.991 13.178l225.48-118.605 225.481 118.605a44.828 44.828 0 0 0 28.423 4.499l5.92-1.434c21.05-6.617 34.496-27.942 30.662-50.297L759.41 608.208l182.413-177.741a44.8 44.8 0 0 0 13.062-25.64l.47-6.074c.209-22.066-15.92-41.44-38.364-44.702L664.88 317.392Zm-510.2 94.403 223.59-32.489a44.8 44.8 0 0 0 33.732-24.507l99.99-202.588 99.99 202.588 3.158 5.41a44.805 44.805 0 0 0 30.574 19.097l223.527 32.49-161.73 157.703-4.169 4.674a44.802 44.802 0 0 0-8.715 34.98l38.166 222.61L532.84 726.701l-6.713-2.861a44.777 44.777 0 0 0-34.981 2.86L291.128 831.764l38.23-222.61.624-6.233a44.801 44.801 0 0 0-13.509-33.421L154.68 411.795Z"/></svg> No newline at end of file
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the code review:

  1. The code looks to be related to SVG graphics. It appears that the patch is replacing an old SVG graphic with a new one. It is not clear what the purpose of the graphic is, but it should be tested to ensure that it renders correctly.

  2. From a security perspective, it is important to check that the new graphic does not contain any malicious code. Additionally, any changes to the code should be tested to ensure that no unexpected behavior occurs.

  3. The code should be checked for any potential performance issues. Any large or complex graphics should be optimized to ensure that they do not cause any performance degradation.

  4. Generally speaking, the code looks to be well written and should not require any major changes. However, it could be improved by adding comments to explain the purpose of the code. This would make it easier for future developers to understand the code.

Overall, the code looks to be in good condition. With a few minor improvements, it should be ready for deployment.

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #1522 (e69723d) into main (a781bb9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head e69723d differs from pull request most recent head 9e5f656. Consider uploading reports for the commit 9e5f656 to get more accurate results

@@           Coverage Diff           @@
##             main    #1522   +/-   ##
=======================================
  Coverage   92.77%   92.77%           
=======================================
  Files         332      332           
  Lines       30892    30897    +5     
  Branches     3555     3556    +1     
=======================================
+ Hits        28661    28666    +5     
  Misses       2231     2231           
Impacted Files Coverage Δ
packages/components/icon/src/definitions.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 615f483 into IDuxFE:main Mar 31, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants