Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(comp:icon): ellipsis icon not right #1522

Merged
merged 1 commit into from
Mar 31, 2023
Merged

fix(comp:icon): ellipsis icon not right #1522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/icon/demo/all.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ export const allIcons = [
'down',
'download',
'edit',
'ellipsis-vertical',
'ellipsis',
'empty',
'environment',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the review

  1. There is no typos or syntax errors in the code patch, which is a good sign for code quality.

  2. The new icon 'ellipsis-vertical' appears to be added correctly in the list of icons.

  3. It would be nice if the code follows a consistent style and indentation.

  4. It is good to have some basic tests on the code patch to make sure it works as expected.

Expand Down
9 changes: 7 additions & 2 deletions packages/components/icon/src/definitions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,9 +330,14 @@ export const Edit = {
svg: '<svg viewBox="0 0 1024 1024" focusable="false"><path d="M910.208 276.672a12.8 12.8 0 0 1 2.112 15.36l-2.176 2.752-512.32 508.992-245.632 83.968a12.8 12.8 0 0 1-16.256-16.064l80.832-248.96 512.448-508.992a12.8 12.8 0 0 1 18.048 0l162.944 162.944zm-81.6 8.832-90.496-90.496-465.28 462.208-44.352 136.768 134.72-46.08 465.408-462.4zM960 908.8v38.4a12.8 12.8 0 0 1-12.8 12.8H76.8A12.8 12.8 0 0 1 64 947.2v-38.4c0-7.04 5.76-12.8 12.8-12.8h870.4c7.04 0 12.8 5.76 12.8 12.8z"/></svg>',
}

export const EllipsisVertical = {
name: 'ellipsis-vertical',
svg: '<svg viewBox="0 0 1024 1024" focusable="false"><path d="M576 768c0 4.202-.41 8.364-1.23 12.486a63.86 63.86 0 0 1-3.642 12.006 63.829 63.829 0 0 1-5.914 11.064 63.878 63.878 0 0 1-7.959 9.699 63.878 63.878 0 0 1-9.699 7.96 63.829 63.829 0 0 1-11.064 5.913 63.827 63.827 0 0 1-12.006 3.642A63.83 63.83 0 0 1 512 832a63.83 63.83 0 0 1-12.486-1.23 63.835 63.835 0 0 1-12.006-3.642 63.839 63.839 0 0 1-11.064-5.914 63.857 63.857 0 0 1-9.699-7.959 63.866 63.866 0 0 1-7.96-9.699 63.833 63.833 0 0 1-5.913-11.064 63.839 63.839 0 0 1-3.642-12.006A63.847 63.847 0 0 1 448 768c0-4.202.41-8.364 1.23-12.486a63.839 63.839 0 0 1 3.642-12.006 63.833 63.833 0 0 1 5.914-11.064 63.866 63.866 0 0 1 7.96-9.699 63.857 63.857 0 0 1 9.698-7.96 63.839 63.839 0 0 1 11.064-5.913 63.868 63.868 0 0 1 12.006-3.643A63.861 63.861 0 0 1 512 704c4.202 0 8.364.41 12.486 1.23a63.86 63.86 0 0 1 12.006 3.642 63.829 63.829 0 0 1 11.064 5.914 63.878 63.878 0 0 1 9.699 7.959 63.878 63.878 0 0 1 7.96 9.699 63.829 63.829 0 0 1 5.913 11.064 63.86 63.86 0 0 1 3.643 12.006A63.862 63.862 0 0 1 576 768Zm0-512c0 4.202-.41 8.364-1.23 12.486a63.86 63.86 0 0 1-3.642 12.006 63.829 63.829 0 0 1-5.914 11.064 63.878 63.878 0 0 1-7.959 9.699 63.878 63.878 0 0 1-9.699 7.96 63.829 63.829 0 0 1-11.064 5.913 63.86 63.86 0 0 1-12.006 3.643A63.862 63.862 0 0 1 512 320c-4.202 0-8.364-.41-12.486-1.23a63.868 63.868 0 0 1-12.006-3.642 63.839 63.839 0 0 1-11.064-5.914 63.857 63.857 0 0 1-9.699-7.959 63.866 63.866 0 0 1-7.96-9.699 63.833 63.833 0 0 1-5.913-11.064 63.839 63.839 0 0 1-3.642-12.006A63.847 63.847 0 0 1 448 256c0-4.202.41-8.364 1.23-12.486a63.847 63.847 0 0 1 3.642-12.006 63.843 63.843 0 0 1 5.914-11.064 63.846 63.846 0 0 1 7.96-9.699 63.846 63.846 0 0 1 9.698-7.96 63.843 63.843 0 0 1 11.064-5.913 63.847 63.847 0 0 1 12.006-3.642A63.846 63.846 0 0 1 512 192c4.202 0 8.364.41 12.486 1.23a63.839 63.839 0 0 1 12.006 3.642 63.833 63.833 0 0 1 11.064 5.914 63.866 63.866 0 0 1 9.699 7.96 63.857 63.857 0 0 1 7.96 9.698 63.839 63.839 0 0 1 5.913 11.064 63.868 63.868 0 0 1 3.643 12.006A63.861 63.861 0 0 1 576 256Zm0 256c0 4.202-.41 8.364-1.23 12.486a63.86 63.86 0 0 1-3.642 12.006 63.829 63.829 0 0 1-5.914 11.064 63.878 63.878 0 0 1-7.959 9.699 63.878 63.878 0 0 1-9.699 7.96 63.829 63.829 0 0 1-11.064 5.913 63.827 63.827 0 0 1-12.006 3.642A63.83 63.83 0 0 1 512 576a63.83 63.83 0 0 1-12.486-1.23 63.835 63.835 0 0 1-12.006-3.642 63.839 63.839 0 0 1-11.064-5.914 63.857 63.857 0 0 1-9.699-7.959 63.866 63.866 0 0 1-7.96-9.699 63.833 63.833 0 0 1-5.913-11.064 63.839 63.839 0 0 1-3.642-12.006A63.847 63.847 0 0 1 448 512c0-4.202.41-8.364 1.23-12.486a63.839 63.839 0 0 1 3.642-12.006 63.833 63.833 0 0 1 5.914-11.064 63.866 63.866 0 0 1 7.96-9.699 63.857 63.857 0 0 1 9.698-7.96 63.839 63.839 0 0 1 11.064-5.913 63.868 63.868 0 0 1 12.006-3.643A63.861 63.861 0 0 1 512 448c4.202 0 8.364.41 12.486 1.23a63.86 63.86 0 0 1 12.006 3.642 63.829 63.829 0 0 1 11.064 5.914 63.878 63.878 0 0 1 9.699 7.959 63.878 63.878 0 0 1 7.96 9.699 63.829 63.829 0 0 1 5.913 11.064 63.86 63.86 0 0 1 3.643 12.006A63.862 63.862 0 0 1 576 512Z"/></svg>',
}

export const Ellipsis = {
name: 'ellipsis',
svg: '<svg viewBox="0 0 1024 1024" focusable="false"><path d="M576 768c0 4.202-.41 8.364-1.23 12.486a63.86 63.86 0 0 1-3.642 12.006 63.829 63.829 0 0 1-5.914 11.064 63.878 63.878 0 0 1-7.959 9.699 63.878 63.878 0 0 1-9.699 7.96 63.829 63.829 0 0 1-11.064 5.913 63.827 63.827 0 0 1-12.006 3.642A63.83 63.83 0 0 1 512 832a63.83 63.83 0 0 1-12.486-1.23 63.835 63.835 0 0 1-12.006-3.642 63.839 63.839 0 0 1-11.064-5.914 63.857 63.857 0 0 1-9.699-7.959 63.866 63.866 0 0 1-7.96-9.699 63.833 63.833 0 0 1-5.913-11.064 63.839 63.839 0 0 1-3.642-12.006A63.847 63.847 0 0 1 448 768c0-4.202.41-8.364 1.23-12.486a63.839 63.839 0 0 1 3.642-12.006 63.833 63.833 0 0 1 5.914-11.064 63.866 63.866 0 0 1 7.96-9.699 63.857 63.857 0 0 1 9.698-7.96 63.839 63.839 0 0 1 11.064-5.913 63.868 63.868 0 0 1 12.006-3.643A63.861 63.861 0 0 1 512 704c4.202 0 8.364.41 12.486 1.23a63.86 63.86 0 0 1 12.006 3.642 63.829 63.829 0 0 1 11.064 5.914 63.878 63.878 0 0 1 9.699 7.959 63.878 63.878 0 0 1 7.96 9.699 63.829 63.829 0 0 1 5.913 11.064 63.86 63.86 0 0 1 3.643 12.006A63.862 63.862 0 0 1 576 768Zm0-512c0 4.202-.41 8.364-1.23 12.486a63.86 63.86 0 0 1-3.642 12.006 63.829 63.829 0 0 1-5.914 11.064 63.878 63.878 0 0 1-7.959 9.699 63.878 63.878 0 0 1-9.699 7.96 63.829 63.829 0 0 1-11.064 5.913 63.86 63.86 0 0 1-12.006 3.643A63.862 63.862 0 0 1 512 320c-4.202 0-8.364-.41-12.486-1.23a63.868 63.868 0 0 1-12.006-3.642 63.839 63.839 0 0 1-11.064-5.914 63.857 63.857 0 0 1-9.699-7.959 63.866 63.866 0 0 1-7.96-9.699 63.833 63.833 0 0 1-5.913-11.064 63.839 63.839 0 0 1-3.642-12.006A63.847 63.847 0 0 1 448 256c0-4.202.41-8.364 1.23-12.486a63.847 63.847 0 0 1 3.642-12.006 63.843 63.843 0 0 1 5.914-11.064 63.846 63.846 0 0 1 7.96-9.699 63.846 63.846 0 0 1 9.698-7.96 63.843 63.843 0 0 1 11.064-5.913 63.847 63.847 0 0 1 12.006-3.642A63.846 63.846 0 0 1 512 192c4.202 0 8.364.41 12.486 1.23a63.839 63.839 0 0 1 12.006 3.642 63.833 63.833 0 0 1 11.064 5.914 63.866 63.866 0 0 1 9.699 7.96 63.857 63.857 0 0 1 7.96 9.698 63.839 63.839 0 0 1 5.913 11.064 63.868 63.868 0 0 1 3.643 12.006A63.861 63.861 0 0 1 576 256Zm0 256c0 4.202-.41 8.364-1.23 12.486a63.86 63.86 0 0 1-3.642 12.006 63.829 63.829 0 0 1-5.914 11.064 63.878 63.878 0 0 1-7.959 9.699 63.878 63.878 0 0 1-9.699 7.96 63.829 63.829 0 0 1-11.064 5.913 63.827 63.827 0 0 1-12.006 3.642A63.83 63.83 0 0 1 512 576a63.83 63.83 0 0 1-12.486-1.23 63.835 63.835 0 0 1-12.006-3.642 63.839 63.839 0 0 1-11.064-5.914 63.857 63.857 0 0 1-9.699-7.959 63.866 63.866 0 0 1-7.96-9.699 63.833 63.833 0 0 1-5.913-11.064 63.839 63.839 0 0 1-3.642-12.006A63.847 63.847 0 0 1 448 512c0-4.202.41-8.364 1.23-12.486a63.839 63.839 0 0 1 3.642-12.006 63.833 63.833 0 0 1 5.914-11.064 63.866 63.866 0 0 1 7.96-9.699 63.857 63.857 0 0 1 9.698-7.96 63.839 63.839 0 0 1 11.064-5.913 63.868 63.868 0 0 1 12.006-3.643A63.861 63.861 0 0 1 512 448c4.202 0 8.364.41 12.486 1.23a63.86 63.86 0 0 1 12.006 3.642 63.829 63.829 0 0 1 11.064 5.914 63.878 63.878 0 0 1 9.699 7.959 63.878 63.878 0 0 1 7.96 9.699 63.829 63.829 0 0 1 5.913 11.064 63.86 63.86 0 0 1 3.643 12.006A63.862 63.862 0 0 1 576 512Z"/></svg>',
svg: '<svg viewBox="0 0 1024 1024" focusable="false"><defs><style/></defs><path d="M768 448a64 64 0 1 0 0 128 64 64 0 1 0 0-128Zm-256 0a64 64 0 1 0 0 128 64 64 0 1 0 0-128Zm-256 0a64 64 0 1 0 0 128 64 64 0 1 0 0-128Z"/></svg>',
}

export const Empty = {
Expand Down Expand Up @@ -917,7 +922,7 @@ export const StarFilled = {

export const Star = {
name: 'star',
svg: '<svg viewBox="0 0 1024 1024" focusable="false"><path fill-rule="evenodd" d="M664.88 317.392 552.158 88.983a44.801 44.801 0 0 0-20.346-20.347c-22.188-10.95-49.051-1.84-60.002 20.347L359.024 317.392l-252.048 36.66a44.8 44.8 0 0 0-25.639 13.063l-4.652 5.613c-12.372 17.666-10.484 42.195 5.462 57.739l182.35 177.741L221.5 859.354a44.804 44.804 0 0 0 4.502 28.422l3.51 5.632c12.885 17.632 37.081 23.642 56.991 13.178l225.48-118.605 225.481 118.605a44.828 44.828 0 0 0 28.423 4.499l5.92-1.434c21.05-6.617 34.496-27.942 30.662-50.297l-43.059-251.146 182.413-177.741a44.8 44.8 0 0 0 13.062-25.64l.47-6.074c.209-22.066-15.92-41.44-38.364-44.702L664.88 317.392Zm-510.2 94.403 223.59-32.489a44.8 44.8 0 0 0 33.732-24.507l99.99-202.588 99.99 202.588 3.158 5.41a44.805 44.805 0 0 0 30.574 19.097l223.527 32.49-161.73 157.703-4.169 4.674a44.802 44.802 0 0 0-8.715 34.98l38.166 222.61L532.84 726.701l-6.713-2.861a44.777 44.777 0 0 0-34.981 2.86L291.128 831.764l38.23-222.61.624-6.233a44.801 44.801 0 0 0-13.509-33.421L154.68 411.795Z"/></svg>',
svg: '<svg viewBox="0 0 1024 1024" focusable="false"><path fill-rule="evenodd" d="M664.88 317.392 552.158 88.983a44.801 44.801 0 0 0-20.346-20.347c-22.188-10.95-49.051-1.84-60.002 20.347L359.024 317.392l-252.048 36.66a44.8 44.8 0 0 0-25.639 13.063l-4.652 5.613c-12.372 17.666-10.484 42.195 5.462 57.739l182.35 177.741L221.5 859.354a44.804 44.804 0 0 0 4.502 28.422l3.51 5.632c12.885 17.632 37.081 23.642 56.991 13.178l225.48-118.605 225.481 118.605a44.828 44.828 0 0 0 28.423 4.499l5.92-1.434c21.05-6.617 34.496-27.942 30.662-50.297L759.41 608.208l182.413-177.741a44.8 44.8 0 0 0 13.062-25.64l.47-6.074c.209-22.066-15.92-41.44-38.364-44.702L664.88 317.392Zm-510.2 94.403 223.59-32.489a44.8 44.8 0 0 0 33.732-24.507l99.99-202.588 99.99 202.588 3.158 5.41a44.805 44.805 0 0 0 30.574 19.097l223.527 32.49-161.73 157.703-4.169 4.674a44.802 44.802 0 0 0-8.715 34.98l38.166 222.61L532.84 726.701l-6.713-2.861a44.777 44.777 0 0 0-34.981 2.86L291.128 831.764l38.23-222.61.624-6.233a44.801 44.801 0 0 0-13.509-33.421L154.68 411.795Z"/></svg>',
}

export const Stop = {
Expand Down
1 change: 1 addition & 0 deletions scripts/gulp/icons/assets/ellipsis-vertical.svg
View file
Open in desktop
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion scripts/gulp/icons/assets/ellipsis.svg
View file
Open in desktop
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion scripts/gulp/icons/assets/star.svg
View file
Open in desktop
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.