Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:theme): store theme style reference count on style element #1907

Merged
merged 1 commit into from May 7, 2024

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

在微前端框架中,如果存在了两个版本的idux,子应用的themeProvider上下文销毁时,会清除掉全局的主题变量style元素

What is the new behavior?

修复以上问题,将style元素的引用次数绑定在style元素上

Other information

Copy link

idux-bot bot commented Apr 24, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (425def0) to head (d4d8119).
Report is 1 commits behind head on main.

❗ Current head d4d8119 differs from pull request most recent head 578508f. Consider uploading reports for the commit 578508f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1907   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files         359      359           
  Lines       35285    35285           
  Branches     2807     2807           
=======================================
  Hits        32023    32023           
  Misses       3262     3262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sallerli1 sallerli1 merged commit ff062cd into IDuxFE:main May 7, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant