Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk:scroll): virtual scroll couldn't scroll under firefox #1946

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

  1. 虚拟滚动容器,在firefox中,滚轮滚动失效
  2. 横向的虚拟滚动,在firefox中,横向滚动条的宽度不正确

What is the new behavior?

修复以上问题

Other information

在firefox下,添加一个height: 0 的元素并不能真正撑开容器的scrollHeight,需要设置 height 1px

Copy link

idux-bot bot commented Jul 4, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@8e17e47). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1946   +/-   ##
=======================================
  Coverage        ?   90.70%           
=======================================
  Files           ?      360           
  Lines           ?    35595           
  Branches        ?     3863           
=======================================
  Hits            ?    32286           
  Misses          ?     3309           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sallerli1 sallerli1 merged commit 9c81358 into IDuxFE:main Jul 4, 2024
9 checks passed
@sallerli1 sallerli1 deleted the fix-virtual-scroll-firefox branch July 4, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant