-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(table): modify table functions and style #672
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## main #672 +/- ##
==========================================
+ Coverage 83.82% 85.35% +1.52%
==========================================
Files 396 396
Lines 9972 9940 -32
Branches 2301 2297 -4
==========================================
+ Hits 8359 8484 +125
+ Misses 1613 1456 -157
Continue to review full report at Codecov.
|
493e67c
to
20e6aad
Compare
packages/components/icon/demo/all.ts
Outdated
@@ -166,6 +166,7 @@ export const allIcons = [ | |||
'stop', | |||
'swap', | |||
'sync', | |||
'table-filter', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个就叫 filter 吧
@@ -840,6 +840,11 @@ export const Sync = { | |||
svg: '<svg viewBox="64 64 896 896"><path d="M145.344 254.528 301.696 410.88a12.8 12.8 0 0 1-12.608 10.624h-150.4a384 384 0 0 0 588.48 408.576l46.016 45.888A448 448 0 0 1 73.152 421.504h-1.984l3.52-7.168a445.76 445.76 0 0 1 70.592-159.808zM512 64a448 448 0 0 1 353.472 723.328L712 633.792l-.64-.896a12.8 12.8 0 0 1 11.52-18.496h159.36a384 384 0 0 0-603.52-407.424l-45.568-45.632A446.08 446.08 0 0 1 512 64z"/></svg>', | |||
} | |||
|
|||
export const TableFilter = { | |||
name: 'table-filter', | |||
svg: '<svg viewBox="0 0 16 16"><path fill-rule="evenodd" d="M1.659 3.259a.2.2 0 0 1-.059-.142V1.8c0-.11.09-.2.2-.2h12.4c.11 0 .2.09.2.2v1.317a.2.2 0 0 1-.059.142L9.6 8v6.276a.2.2 0 0 1-.11.18l-2.8 1.4a.2.2 0 0 1-.29-.18V8L1.659 3.259Z"/></svg>', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
viewBox 不对?
@@ -16,6 +16,7 @@ order: 0 | |||
| --- | --- | --- | --- | --- | --- | | |||
| `v-model:expandedRowKeys` | 展开行的 `key` 数组 | `(string \| number)[]` | - | - | - | | |||
| `v-model:selectedRowKeys` | 选中行的 `key` 数组 | `(string \| number)[]` | - | - | - | | |||
| `v-model:expandAllStatus` | 全部展开的状态 | `boolean` | - | - | - | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `v-model:expandAllStatus` | 全部展开的状态 | `boolean` | - | - | - | | |
| `v-model:expandAll` | 是否全部展开 | `boolean` | - | - | - | |
| --- | --- | --- | --- | --- | --- | | ||
| `filters` | 筛选项 | `{ text: string, value: any }[]` | - | - | - | | ||
| `filterBy` | 当前激活的筛选项 | `any[]` | - | - | - | | ||
| `handleFilter` | 筛选处理函数 | `(currFilterBy: any[], record: T) => boolean` | - | - | - | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `handleFilter` | 筛选处理函数 | `(currFilterBy: any[], record: T) => boolean` | - | - | - | | |
| `filter` | 本地模式下的筛选函数 | `(currFilterBy: any[], record: T) => boolean` | - | - | - | |
@@ -41,6 +46,8 @@ export const tableProps = { | |||
tags: IxPropTypes.object<TableTags>(), | |||
virtual: IxPropTypes.bool.def(false), | |||
|
|||
overlayTarget: ɵPortalTargetDef, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个先不提供吧
@@ -53,15 +60,18 @@ export const tableProps = { | |||
export type TableProps = IxInnerPropTypes<typeof tableProps> | |||
export type TablePublicProps = IxPublicPropTypes<typeof tableProps> | |||
export interface TableBindings { | |||
scrollTo: VirtualScrollToFn | |||
expandAll: ExpandAllContext['expandAll'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个也先不提供吧,另外把 scrollTo 加来回来,应该是我之前漏写了。
20e6aad
to
17ce84c
Compare
1. add tree table indent support 2. fix tree table sort function 3. fix sort orderby(was't controlled previously) 4. add filter function for table 5. expandable column now extends base column(usual data column) 6. modify table style according to new design
17ce84c
to
4c7f62f
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
see commit details for full info
Other information