Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:typography): fix typography disabled style #687

Merged
merged 2 commits into from
Dec 30, 2021

Conversation

Lincoln-xzc
Copy link
Contributor

@Lincoln-xzc Lincoln-xzc commented Dec 29, 2021

typography disable is true, child a label can not be grayed out

"fix #567"

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

typography disable is true, child a label can not be grayed out

"fix IDuxFE#567"
@idux-bot
Copy link

idux-bot bot commented Dec 29, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #687 (aab8096) into main (a1f895b) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head aab8096 differs from pull request most recent head f8c907e. Consider uploading reports for the commit f8c907e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #687      +/-   ##
==========================================
- Coverage   83.95%   83.94%   -0.02%     
==========================================
  Files         396      394       -2     
  Lines        9918     9901      -17     
  Branches     2281     2282       +1     
==========================================
- Hits         8327     8311      -16     
+ Misses       1591     1590       -1     
Impacted Files Coverage Δ
packages/components/rate/src/Rate.tsx 73.75% <0.00%> (-0.33%) ⬇️
packages/components/switch/src/Switch.tsx 90.62% <0.00%> (-0.29%) ⬇️
packages/components/radio/src/Radio.tsx 86.44% <0.00%> (-0.23%) ⬇️
packages/components/slider/src/useSlider.ts 57.75% <0.00%> (-0.23%) ⬇️
...ages/components/input-number/src/useInputNumber.ts 76.41% <0.00%> (-0.23%) ⬇️
packages/components/checkbox/src/Checkbox.tsx 95.58% <0.00%> (-0.07%) ⬇️
packages/cdk/forms/src/utils.ts 92.30% <0.00%> (ø)
packages/components/input/src/Input.tsx 100.00% <0.00%> (ø)
packages/components/select/src/token.ts 100.00% <0.00%> (ø)
packages/components/input/src/useInput.ts 100.00% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1f895b...f8c907e. Read the comment docs.

BREAKING CHANGE: size is used instead of gap
Copy link
Member

@danranVm danranVm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danranVm danranVm merged commit 41d5225 into IDuxFE:main Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[comp:typography]
3 participants