Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp: space): replace gap prop with size #670

Merged
merged 1 commit into from
Dec 28, 2021

Conversation

liuzaijiang
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

更新back-top less变量

@idux-bot
Copy link

idux-bot bot commented Dec 27, 2021

This preview will be available after the AzureCI is passed.

Copy link
Member

@danranVm danranVm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是一个破坏性变更,需要在 commit 的 breaking changes 里声明一下

packages/components/back-top/style/index.less Show resolved Hide resolved
packages/components/config/src/types.ts Outdated Show resolved Hide resolved
packages/components/config/src/defaultConfig.ts Outdated Show resolved Hide resolved
packages/components/space/demo/Basic.vue Show resolved Hide resolved
packages/components/space/demo/CustomSize.vue Outdated Show resolved Hide resolved
packages/components/space/src/types.ts Outdated Show resolved Hide resolved
packages/components/space/src/Space.tsx Outdated Show resolved Hide resolved
packages/components/space/src/types.ts Outdated Show resolved Hide resolved
BREAKING CHANGE: size is used instead of gap
@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #670 (1479892) into main (84116bd) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #670      +/-   ##
==========================================
+ Coverage   83.92%   83.95%   +0.03%     
==========================================
  Files         396      396              
  Lines        9909     9918       +9     
  Branches     2278     2281       +3     
==========================================
+ Hits         8316     8327      +11     
+ Misses       1593     1591       -2     
Impacted Files Coverage Δ
packages/components/space/index.ts 100.00% <ø> (ø)
packages/components/space/src/types.ts 100.00% <ø> (ø)
packages/components/config/src/defaultConfig.ts 100.00% <100.00%> (ø)
packages/components/space/src/Space.tsx 94.91% <100.00%> (+0.17%) ⬆️
packages/components/utils/src/useFormElement.ts 95.65% <0.00%> (ø)
packages/components/modal/src/ModalWrapper.tsx 74.01% <0.00%> (+0.20%) ⬆️
packages/cdk/a11y/src/inputModalityDetector.ts 84.00% <0.00%> (+6.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84116bd...1479892. Read the comment docs.

Copy link
Member

@danranVm danranVm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danranVm danranVm merged commit a1f895b into IDuxFE:main Dec 28, 2021
Lincoln-xzc pushed a commit to Lincoln-xzc/components that referenced this pull request Dec 30, 2021
BREAKING CHANGE: size is used instead of gap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants