feat(comp:image): add image and imageViewer components #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## main #706 +/- ##
==========================================
+ Coverage 85.30% 85.43% +0.13%
==========================================
Files 396 397 +1
Lines 9947 10078 +131
Branches 2302 2340 +38
==========================================
+ Hits 8485 8610 +125
- Misses 1462 1468 +6
Continue to review full report at Codecov.
|
typistZxd
force-pushed
the
feat-image-zxd
branch
3 times, most recently
from
188c5b9
to
4f09b0c
Compare
typistZxd
changed the title
typistZxd
force-pushed
the
feat-image-zxd
branch
2 times, most recently
from
98a4b20
to
89f7147
Compare
typistZxd
force-pushed
the
feat-image-zxd
branch
from
89f7147
to
bc67af2
Compare
danranVm
approved these changes
Jan 13, 2022
| inheritAttrs: false, | ||
| props: imageProps, | ||
| setup(props, { attrs, slots }) { | ||
| const { class: className, style, ...rest } = attrs |
There was a problem hiding this comment.
attrs 要在 computed 或者 render 内部解构，setup 是一次性调用的。
| setup(props) { | ||
| const common = useGlobalConfig('common') | ||
| const config = useGlobalConfig('imageViewer') | ||
| const [visible] = useControlledProp(props, 'visible', false) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #698
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
add image and imageViewer components
Other information