-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(comp:image): add image and imageViewer components #706
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## main #706 +/- ##
==========================================
+ Coverage 85.30% 85.43% +0.13%
==========================================
Files 396 397 +1
Lines 9947 10078 +131
Branches 2302 2340 +38
==========================================
+ Hits 8485 8610 +125
- Misses 1462 1468 +6
Continue to review full report at Codecov.
|
188c5b9
to
4f09b0c
Compare
98a4b20
to
89f7147
Compare
89f7147
to
bc67af2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有几个问题,后续 PR 修改吧。
inheritAttrs: false, | ||
props: imageProps, | ||
setup(props, { attrs, slots }) { | ||
const { class: className, style, ...rest } = attrs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
attrs 要在 computed 或者 render 内部解构,setup 是一次性调用的。
setup(props) { | ||
const common = useGlobalConfig('common') | ||
const config = useGlobalConfig('imageViewer') | ||
const [visible] = useControlledProp(props, 'visible', false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set 呢?
fix #698
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
add image and imageViewer components
Other information