Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cdk:scroll): turn to native scrollbar #847

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

sallerli1
Copy link
Contributor

VirtualScroll now use vanilla scrollbar instead of inset scrollbar

fix(cdk:scroll): fix VirtualScroll horizontal scroll behavior

fix(comp:table): scrollbar th cell is now visible under virtual mode

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

虚拟滚动下不显示横向的滚动条,横向混动行为不正常
虚拟滚动使用了模拟的滚动条
表格的固定列在虚拟滚动下不生效

What is the new behavior?

虚拟滚动的横向滚动功能正常,包括 shift + wheel
去掉模拟滚动条,改用原生滚动条实现
表格固定列在虚拟滚动下和常规场景下表现一致

Other information

VirtualScroll now use vanilla scrollbar instead of inset scrollbar

fix(cdk:scroll): fix VirtualScroll horizontal scroll behavior

fix(comp:table): scrollbar th cell is now visible under virtual mode
@idux-bot
Copy link

idux-bot bot commented Apr 13, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #847 (0ac9be7) into main (675a3c6) will decrease coverage by 0.01%.
The diff coverage is 85.00%.

@@            Coverage Diff             @@
##             main     #847      +/-   ##
==========================================
- Coverage   93.30%   93.29%   -0.02%     
==========================================
  Files         635      633       -2     
  Lines       60783    60449     -334     
  Branches     7278     7234      -44     
==========================================
- Hits        56716    56393     -323     
+ Misses       4067     4056      -11     
Impacted Files Coverage Δ
...ackages/cdk/scroll/__tests__/virtualScroll.spec.ts 93.95% <ø> (-0.86%) ⬇️
.../cdk/scroll/src/virtual/composables/useScrollTo.ts 88.42% <ø> (+0.62%) ⬆️
packages/components/table/src/main/MainTable.tsx 76.72% <0.00%> (ø)
...ackages/cdk/scroll/src/virtual/contents/Holder.tsx 95.32% <66.66%> (-0.90%) ⬇️
packages/cdk/scroll/src/virtual/VirtualScroll.tsx 100.00% <100.00%> (+5.22%) ⬆️
packages/cdk/scroll/src/virtual/token.ts 100.00% <100.00%> (ø)
...ages/components/table/src/composables/useScroll.ts 93.63% <100.00%> (ø)
packages/components/table/src/main/body/Body.tsx 95.31% <100.00%> (+0.07%) ⬆️
...s/components/table/src/main/body/RenderBodyRow.tsx 97.61% <100.00%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 675a3c6...0ac9be7. Read the comment docs.

Copy link
Member

@danranVm danranVm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sallerli1 sallerli1 changed the title refactor(cdk:scroll): turn to vanilla scrollbar refactor(cdk:scroll): turn to native scrollbar Apr 14, 2022
@danranVm danranVm merged commit 95df1b9 into IDuxFE:main Apr 14, 2022
@sallerli1 sallerli1 deleted the refactor-virtual-scroll-saller branch February 20, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants