Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp: select): update overlay on selector resize #851

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

danranVm
Copy link
Member

refactor(cdk: scroll): use getKey instand of itemKey

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

refactor(cdk: scroll): use getKey instand of itemKey
@idux-bot
Copy link

idux-bot bot commented Apr 18, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #851 (9c0dcc0) into main (09e6ac3) will increase coverage by 0.36%.
The diff coverage is 73.86%.

@@            Coverage Diff             @@
##             main     #851      +/-   ##
==========================================
+ Coverage   93.29%   93.65%   +0.36%     
==========================================
  Files         633      647      +14     
  Lines       60474    62759    +2285     
  Branches     7238     7572     +334     
==========================================
+ Hits        56418    58776    +2358     
+ Misses       4056     3983      -73     
Impacted Files Coverage Δ
packages/cdk/scroll/index.ts 100.00% <ø> (ø)
packages/components/table/src/main/MainTable.tsx 76.72% <0.00%> (ø)
packages/components/utils/src/useKey.ts 56.09% <35.71%> (-43.91%) ⬇️
...mponents/select/src/composables/useOverlayState.ts 92.30% <66.66%> (-2.82%) ⬇️
...es/cdk/scroll/src/virtual/composables/useGetKey.ts 94.44% <83.33%> (+0.15%) ⬆️
...ackages/cdk/scroll/__tests__/virtualScroll.spec.ts 93.95% <100.00%> (ø)
packages/cdk/scroll/src/virtual/types.ts 100.00% <100.00%> (ø)
...ents/_private/checkable-list/src/CheckableList.tsx 93.49% <100.00%> (ø)
...ages/components/_private/selector/src/Selector.tsx 99.14% <100.00%> (+2.06%) ⬆️
packages/components/_private/selector/src/types.ts 100.00% <100.00%> (ø)
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09e6ac3...9c0dcc0. Read the comment docs.

@danranVm danranVm merged commit 24f173e into IDuxFE:main Apr 18, 2022
@danranVm danranVm deleted the feat-cascader branch April 18, 2022 07:28
sallerli1 pushed a commit to sallerli1/idux that referenced this pull request Apr 25, 2022
refactor(cdk: scroll): use getKey instand of itemKey
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant