Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp: cascader): add cascader component #857

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

danranVm
Copy link
Member

fix #797

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Apr 24, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #857 (5ad19d5) into main (2a9e7b0) will decrease coverage by 0.13%.
The diff coverage is 86.61%.

@@            Coverage Diff             @@
##             main     #857      +/-   ##
==========================================
- Coverage   93.66%   93.52%   -0.14%     
==========================================
  Files         647      658      +11     
  Lines       62994    64466    +1472     
  Branches     7697     7852     +155     
==========================================
+ Hits        59004    60293    +1289     
- Misses       3990     4173     +183     
Impacted Files Coverage Δ
...ges/components/tree-select/src/content/Content.tsx 89.36% <ø> (-0.09%) ⬇️
packages/components/tree-select/src/types.ts 99.24% <ø> (-0.02%) ⬇️
packages/components/tree/src/types.ts 99.43% <ø> (-0.01%) ⬇️
packages/components/select/src/Select.tsx 92.69% <40.00%> (-1.26%) ⬇️
packages/components/tree-select/src/TreeSelect.tsx 97.39% <40.00%> (-1.55%) ⬇️
...mponents/cascader/src/composables/useExpandable.ts 42.10% <42.10%> (ø)
...mponents/cascader/src/composables/useSearchable.ts 55.00% <55.00%> (ø)
packages/components/cascader/src/utils/index.ts 61.53% <61.53%> (ø)
...omponents/cascader/src/contents/OverlayContent.tsx 82.14% <82.14%> (ø)
...nents/cascader/src/composables/useSelectedState.ts 82.57% <82.57%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a9e7b0...5ad19d5. Read the comment docs.

@danranVm danranVm force-pushed the feat-cascader branch 3 times, most recently from ade1b65 to 334b560 Compare April 25, 2022 11:08
@danranVm danranVm merged commit 50fb584 into IDuxFE:main Apr 25, 2022
@danranVm danranVm deleted the feat-cascader branch April 25, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[comp:cascader] we need cascader component
1 participant