Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp: tree-selct): add customAdditional,getKey and overlayContainer #869

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

danranVm
Copy link
Member

synchronization with cascader and tree

BREAKING CHANGE: nodeKey was deprecated, please use getKey
instead. target was deprecated, please use overlayContainer instead. dataSource.additional was
deprecated, please use customAdditional instead.

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Apr 28, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #869 (c699dcf) into main (d10f5e0) will decrease coverage by 0.04%.
The diff coverage is 88.72%.

@@            Coverage Diff             @@
##             main     #869      +/-   ##
==========================================
- Coverage   93.50%   93.45%   -0.05%     
==========================================
  Files         657      657              
  Lines       64594    64760     +166     
  Branches     7845     7848       +3     
==========================================
+ Hits        60396    60522     +126     
- Misses       4198     4238      +40     
Impacted Files Coverage Δ
...mponents/cascader/src/composables/useSearchable.ts 46.80% <10.00%> (-8.20%) ⬇️
...ges/components/tree-select/src/content/Content.tsx 86.63% <58.33%> (-2.73%) ⬇️
...kages/components/tree/src/composables/useEvents.ts 41.00% <66.66%> (ø)
packages/components/cascader/src/Cascader.tsx 95.74% <72.72%> (+0.06%) ⬆️
packages/components/tree-select/src/TreeSelect.tsx 95.67% <85.71%> (-1.73%) ⬇️
..._private/selector/src/composables/useInputState.ts 88.33% <88.88%> (+0.40%) ⬆️
packages/components/select/src/Select.tsx 93.67% <89.47%> (+0.56%) ⬆️
...ages/components/_private/selector/src/Selector.tsx 99.13% <100.00%> (ø)
...ges/components/cascader/__tests__/cascader.spec.ts 100.00% <100.00%> (ø)
...omponents/cascader/src/contents/OverlayContent.tsx 82.14% <100.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d10f5e0...c699dcf. Read the comment docs.

synchronization with cascader and tree

BREAKING CHANGE: `nodeKey` was deprecated, please use `getKey`
instead. `target` was deprecated, please use `overlayContainer` instead. `dataSource.additional` was
deprecated, please use `customAdditional` instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant