Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp: tree): expand the node being hover, when dragging #927

Merged
merged 2 commits into from
May 25, 2022

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

拖拽节点到一个为展开父级节点时,悬浮1秒后,没有正常展开

What is the new behavior?

正常展开

Other information

@idux-bot
Copy link

idux-bot bot commented May 25, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #927 (271b35d) into main (2aa0e91) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #927      +/-   ##
==========================================
- Coverage   93.38%   93.38%   -0.01%     
==========================================
  Files         679      679              
  Lines       66644    66660      +16     
  Branches     5881     5887       +6     
==========================================
+ Hits        62238    62251      +13     
- Misses       4406     4409       +3     
Impacted Files Coverage Δ
...ges/components/tree/src/composables/useDragDrop.ts 36.24% <37.50%> (-0.36%) ⬇️
packages/components/table/src/utils/index.ts 85.96% <79.31%> (-7.14%) ⬇️
packages/components/table/index.ts 95.23% <80.00%> (-2.14%) ⬇️
...ges/components/table/src/composables/useColumns.ts 74.00% <87.50%> (+0.18%) ⬆️
packages/components/table/src/column.ts 94.73% <100.00%> (ø)
packages/components/table/src/types.ts 100.00% <100.00%> (ø)
...s/components/tree/src/composables/useExpandable.ts 97.05% <100.00%> (-0.05%) ⬇️
...s/components/tree/src/composables/useSelectable.ts 94.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aa0e91...271b35d. Read the comment docs.

@danranVm danranVm merged commit ae8fdef into IDuxFE:main May 25, 2022
@danranVm danranVm deleted the fix-tree-drag-drop branch May 25, 2022 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant