Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:cascader): the cloned node should have a unique key #940

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented Jun 7, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

复制节点的时候,没有使用唯一的 key, 会导致特定场景下,组件无法销毁的情况。

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Jun 7, 2022

This preview will be available after the AzureCI is passed.

@danranVm danranVm requested a review from brenner8023 June 7, 2022 10:14
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #940 (119c1ef) into main (7161d96) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 119c1ef differs from pull request most recent head 008d9a2. Consider uploading reports for the commit 008d9a2 to get more accurate results

@@           Coverage Diff           @@
##             main     #940   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files         683      683           
  Lines       67031    67033    +2     
  Branches     7910     7910           
=======================================
+ Hits        62498    62500    +2     
  Misses       4533     4533           
Impacted Files Coverage Δ
packages/components/carousel/src/Carousel.tsx 100.00% <100.00%> (ø)
...components/carousel/src/composables/useAutoplay.ts 100.00% <100.00%> (ø)
...ges/components/carousel/src/composables/useWalk.ts 100.00% <100.00%> (ø)
packages/components/carousel/src/types.ts 100.00% <100.00%> (ø)
packages/components/config/src/types.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7161d96...008d9a2. Read the comment docs.

@danranVm danranVm merged commit 45ece7b into IDuxFE:main Jun 7, 2022
@danranVm danranVm deleted the fix-carousel-vnode branch June 7, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants