Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:loading-bar): add LoadingBar component (#971) #1023

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

qingshan-dev
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

What is the new behavior?

开始

image

遮罩

image

错误

image

Other information

@idux-bot
Copy link

idux-bot bot commented Jul 16, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jul 16, 2022

Codecov Report

Merging #1023 (f2db983) into main (6f4d3af) will decrease coverage by 0.21%.
The diff coverage is 89.20%.

❗ Current head f2db983 differs from pull request most recent head 1464855. Consider uploading reports for the commit 1464855 to get more accurate results

@@            Coverage Diff             @@
##             main    #1023      +/-   ##
==========================================
- Coverage   93.96%   93.75%   -0.22%     
==========================================
  Files         308      314       +6     
  Lines       29249    29940     +691     
  Branches     2519     3542    +1023     
==========================================
+ Hits        27485    28069     +584     
- Misses       1764     1871     +107     
Impacted Files Coverage Δ
packages/components/input/src/useInput.ts 92.08% <ø> (-0.17%) ⬇️
packages/components/watermark/src/Watermark.tsx 30.43% <7.14%> (-14.01%) ⬇️
packages/pro/transfer/src/utils.ts 87.21% <28.57%> (-11.06%) ⬇️
packages/pro/form/src/ProForm.tsx 31.57% <31.57%> (ø)
packages/cdk/forms/src/validators.ts 99.17% <66.66%> (-0.83%) ⬇️
packages/components/form/src/FormItem.tsx 97.48% <82.35%> (-1.19%) ⬇️
.../components/loading-bar/src/LoadingBarProvider.tsx 95.26% <95.26%> (ø)
...onents/_private/time-panel/src/TimePanelColumn.tsx 95.65% <97.29%> (-1.23%) ⬇️
packages/cdk/forms/src/controls.ts 100.00% <100.00%> (ø)
packages/cdk/forms/src/types.ts 100.00% <100.00%> (ø)
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f4d3af...1464855. Read the comment docs.

@qingshan-dev qingshan-dev force-pushed the add-loading-bar-component branch 2 times, most recently from 140098d to 2c9be3a Compare July 18, 2022 05:08
packages/components/config/src/types.ts Outdated Show resolved Hide resolved
test.html Outdated Show resolved Hide resolved
tests/utils.ts Outdated Show resolved Hide resolved
packages/components/loading-bar/index.ts Outdated Show resolved Hide resolved
packages/components/loading-bar/src/LoadingBarProvider.tsx Outdated Show resolved Hide resolved
packages/components/loading-bar/src/LoadingBarProvider.tsx Outdated Show resolved Hide resolved
config: LoadingBarConfig,
loadingBarRef: Ref<HTMLElement | undefined>,
): LoadingBarProviderBindings => {
const { loading: loadingConfig, error: errorConfig, finish: finishConfig } = config.animation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里解构了的话,用户就不可以动态的修改这些值了。
另外感觉这个 animation config, 层级有点深了。

@danranVm danranVm merged commit f948786 into IDuxFE:main Jul 25, 2022
@tuchg tuchg linked an issue Jul 26, 2022 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[comp:other] 新增组件 loading-bar
2 participants