-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(comp:loading-bar): add LoadingBar component (#971) #1023
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## main #1023 +/- ##
==========================================
- Coverage 93.96% 93.75% -0.22%
==========================================
Files 308 314 +6
Lines 29249 29940 +691
Branches 2519 3542 +1023
==========================================
+ Hits 27485 28069 +584
- Misses 1764 1871 +107
Continue to review full report at Codecov.
|
38f6c69
to
6568af3
Compare
140098d
to
2c9be3a
Compare
config: LoadingBarConfig, | ||
loadingBarRef: Ref<HTMLElement | undefined>, | ||
): LoadingBarProviderBindings => { | ||
const { loading: loadingConfig, error: errorConfig, finish: finishConfig } = config.animation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里解构了的话,用户就不可以动态的修改这些值了。
另外感觉这个 animation config, 层级有点深了。
2c9be3a
to
95d67f0
Compare
95d67f0
to
1464855
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
What is the new behavior?
开始
遮罩
错误
Other information