Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:form): repair the form-item-input-content centering(#1019) #1032

Merged
merged 2 commits into from
Jul 25, 2022

Conversation

winchesHe
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

The default form controls are all 32 px, and the switch is 28, so swtich is not vertically centered, and so are checkbox, radio, rate, and slider

image
image

What is the new behavior?

image
image
image

Other information

the slider lose it width

image

add flex: 1; to solve

image

@idux-bot
Copy link

idux-bot bot commented Jul 24, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #1032 (f72d6a1) into main (5d023a8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1032   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files         310      310           
  Lines       29648    29648           
  Branches     3510     3510           
=======================================
  Hits        27805    27805           
  Misses       1843     1843           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d023a8...f72d6a1. Read the comment docs.

@winchesHe winchesHe reopened this Jul 24, 2022
Copy link
Member

@danranVm danranVm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danranVm danranVm merged commit 785abb5 into IDuxFE:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants