Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(comp:*): refactor popper initialization logic of overlay #1304

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

What is the new behavior?

Other information

整理overlay的popper初始化相关逻辑,不改变原有功能

@idux-bot
Copy link

idux-bot bot commented Nov 25, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #1304 (9723533) into main (3d8a5c3) will decrease coverage by 0.00%.
The diff coverage is 84.78%.

@@            Coverage Diff             @@
##             main    #1304      +/-   ##
==========================================
- Coverage   93.04%   93.04%   -0.01%     
==========================================
  Files         322      322              
  Lines       29824    29862      +38     
  Branches     3366     3371       +5     
==========================================
+ Hits        27750    27784      +34     
- Misses       2074     2078       +4     
Impacted Files Coverage Δ
...ckages/components/_private/overlay/src/Overlay.tsx 95.52% <84.78%> (-1.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants