Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pro:search): all tags should be displayed when focused #1331

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

sallerli1
Copy link
Contributor

overflowed tag shouldn't show when no segment is active under focused state

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

没有任何搜索项处于激活状态,且复合搜索组件处于聚焦状态时,溢出的标签没有展示

What is the new behavior?

修复以上问题,即使没有任何搜索项处于激活状态,全部标签依然展示完全

Other information

overflowed tag shouldn't show when no segment is active under focused state
@idux-bot
Copy link

idux-bot bot commented Dec 5, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #1331 (20dd0b5) into main (81a673f) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1331   +/-   ##
=======================================
  Coverage   93.13%   93.13%           
=======================================
  Files         324      324           
  Lines       29973    29973           
  Branches     3400     3400           
=======================================
  Hits        27916    27916           
  Misses       2057     2057           
Impacted Files Coverage Δ
packages/pro/search/src/ProSearch.tsx 17.41% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 05478ab into IDuxFE:main Dec 6, 2022
@sallerli1 sallerli1 deleted the fix-pro-search-overflow-focused branch July 4, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants