Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pro:search): remove transition for overlay #1447

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

由于复合搜索的某一个输入框在非激活状态时会隐藏,转换为标签显示,浮层对应的trigger位置会有改变,这时浮层收起的动画显示位置会不正确

What is the new behavior?

暂时去掉复合搜索的浮层动画

Other information

@idux-bot
Copy link

idux-bot bot commented Feb 13, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #1447 (f79ab61) into main (8852db4) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1447   +/-   ##
=======================================
  Coverage   92.98%   92.98%           
=======================================
  Files         327      327           
  Lines       30350    30350           
  Branches     2559     2560    +1     
=======================================
  Hits        28221    28221           
  Misses       2129     2129           
Impacted Files Coverage Δ
packages/pro/search/src/ProSearch.tsx 15.49% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm
Copy link
Member

先作为一个临时解决方案,后面还是得把动画加回来。

@danranVm danranVm merged commit 4c28a78 into IDuxFE:main Feb 15, 2023
@sallerli1 sallerli1 deleted the fix-pro-search-transition branch February 20, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants