test(cdk:forms): update disabled case #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cr-gpt[bot]](https://avatars.githubusercontent.com/in/292659?s=60&v=4){kind=small}
| expect(await control.validate()).toEqual({ | ||
| maxLength: getError('maxLength', control, { actual: 7, isArray: false, maxLength: 5 }), | ||
| }) | ||
|
|
||
| control.setValue('disabled') | ||
| await flushPromises() | ||
|
|
||
| expect(control.disabled.value).toEqual(true) | ||
| expect(control.valid.value).toEqual(true) | ||
| expect(await control.validate()).toEqual(undefined) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
with code review
- In the line 334, it is better to use the variable instead of hard coding the value 'disable'.
- In line 337, it is better to use the variable instead of hard coding the value 'enabled'.
- In line 341, it is better to use the variable instead of hard coding the value 'disabled'.
- In line 345, it is better to check if the control has been set disabled before checking its value.
- In line 349, it is better to check if the control has been set enabled before checking its value.
- The code should have proper comments which can help to understand the code more easily.
|
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## main #1506 +/- ##
=======================================
Coverage 92.75% 92.75%
=======================================
Files 331 331
Lines 30801 30801
Branches 3532 3533 +1
=======================================
Hits 28568 28568
Misses 2233 2233 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
What is the new behavior?
Other information