Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk:scroll): the onScrolledBottom is not triggered #1535

Merged
merged 1 commit into from
Apr 13, 2023
Merged

fix(cdk:scroll): the onScrolledBottom is not triggered #1535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/cdk/scroll/src/virtual/composables/useScrollPlacement.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ export function useScrollPlacement(
}
callEmit(props.onScroll, evt)

if (newScrollTop >= maxScrollHeight.value) {
// 某些情况下(例如浏览器缩放), 会导致 scrollTop 出现小数，newScrollTop 始终小于 maxScrollHeight
// 所以对 newScrollTop 进行了向上取整，避免此种情况的出现。
if (Math.ceil(newScrollTop) >= maxScrollHeight.value) {
callEmit(props.onScrolledBottom)
}
}
Expand Down