Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk:drag-drop): the shard context was not initalized correctly #1537

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

What is the new behavior?

  • 正确使用 createSharedComposable, 保证全局共享的 context 的唯一性

Other information

@idux-bot
Copy link

idux-bot bot commented Apr 17, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #1537 (120afbf) into main (e323867) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 120afbf differs from pull request most recent head 1e82a6c. Consider uploading reports for the commit 1e82a6c to get more accurate results

@@           Coverage Diff           @@
##             main    #1537   +/-   ##
=======================================
  Coverage   92.78%   92.79%           
=======================================
  Files         332      332           
  Lines       30909    30906    -3     
  Branches     3557     3557           
=======================================
  Hits        28678    28678           
+ Misses       2231     2228    -3     
Impacted Files Coverage Δ
packages/cdk/drag-drop/src/utils.ts 58.92% <0.00%> (+2.99%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 1a8793d into IDuxFE:main Apr 17, 2023
@danranVm danranVm deleted the fix-dnd branch April 17, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant