Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:tour): active step incorrect when async #1621

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

在asnyc模式下,即是用了beforeEnter,在进入下一步之前滚动鼠标,会导致当前的step计算不正确

What is the new behavior?

修复以上问题

Other information

@idux-bot
Copy link

idux-bot bot commented Aug 3, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #1621 (fa83cfb) into main (409c280) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head fa83cfb differs from pull request most recent head c44eb75. Consider uploading reports for the commit c44eb75 to get more accurate results

@@           Coverage Diff           @@
##             main    #1621   +/-   ##
=======================================
  Coverage   92.62%   92.62%           
=======================================
  Files         345      345           
  Lines       32194    32199    +5     
  Branches     3677     3677           
=======================================
+ Hits        29820    29825    +5     
  Misses       2374     2374           
Files Changed Coverage Δ
packages/components/tour/src/Tour.tsx 100.00% <100.00%> (ø)
packages/components/tour/src/types.ts 100.00% <100.00%> (ø)

@sallerli1 sallerli1 merged commit cb6d0bf into IDuxFE:main Aug 5, 2023
5 of 7 checks passed
@sallerli1 sallerli1 deleted the fix-tour-target-saller branch July 4, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant